Repository navigation
Conversation
When process_stream() cannot find an eventType it drops the packet with a bare debug line, so a user's debug log cannot show why: the element may be missing, nested elsewhere, or in a namespace pyHik did not expect (as in mezz64#132). Include the packet itself in that line, built only when debug logging is on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
process_stream()finds noeventTypein an alert packet it drops the packet and logs onlyAlert packet carries no event type, ignoring.That line can't tell a missing element apart from one that is nested somewhere else or sits in a namespace pyHik didn't expect.home-assistant/core#183076 is an example. A DS-2DE5425IW-AE on pyHik 0.4.7 logged that line twice during an Intrusion Detection event, and the camera's own email confirmed the event. The likely cause is the namespace switch fixed in #133 (0.4.8), but the log couldn't prove it.
This change puts the packet XML in that debug line, including its namespace. The XML is only serialized when debug logging is enabled. It comes with a test.
🤖 Generated with Claude Code