Conversation
Tested: 134 tests passed; cyclic/shared graph and 2000-level API QA Confidence: high Scope-risk: moderate Constraint: Preserve dispatch to custom child freeze overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow freezing cyclic and deeply nested dictionaries.
Replace unbounded recursive traversal with an identity-visited explicit stack for built-in Dict.freeze. Custom child freeze overrides retain dispatch. Tests cover cycles, 1500-level chain, freeze/unfreeze and subclass overrides.
Validation: 134 tests passed on Python 3.14; public API reproduction passes. Built-in traversal only; custom child freeze overrides remain responsible for their own cyclic traversal. O(number of distinct Dict nodes) visited memory; no changes to nested list handling. Python 3.14 only.
AI assistance: OpenAI Codex prepared this change and regression tests.