Skip to content

Build the nightly from main instead of pushing to the nightly branch - #4538

Open
atalman wants to merge 1 commit into
meta-pytorch:mainfrom
atalman:nightly-from-main
Open

atalman wants to merge 1 commit into
meta-pytorch:mainfrom
atalman:nightly-from-main

Conversation

@atalman

@atalman atalman commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

pytorch/test-infra's trigger_nightly.yml cut the nightly branch of meta-pytorch/torchcomms with GH_PYTORCHBOT_TOKEN, a classic personal access token that the meta-pytorch org now rejects (403). The nightly branch has not moved since 2026-09-09, so no nightly has been built from it. Pushing to it from here would also have to get past the "Meta CLA Enforcement" ruleset, which a commit pushed without a PR cannot satisfy.

Build main directly on a 11:30 UTC schedule instead. The reusable build workflow uploads on trigger-event == schedule, so it does not need the nightly branch. The ref input is set explicitly because it defaults to the nightly branch. A new source-commit job writes the commit sha to the run summary so each nightly can be traced to the commit it was built from. A manual run can upload to the nightly index when publish is set: the workflow then reports schedule as the trigger event to the reusable workflow. The wheel version still comes from BUILD_VERSION, which the reusable workflow sets to <version.txt>.dev for the nightly channel.

Test Plan:

Not run on GitHub yet. After merge, dispatch the workflow to build and check the summary and the build job's checkout. A workflow_dispatch without publish builds main but does not upload; the first scheduled run (11:30 UTC) is the end-to-end check. Tracking: pytorch/test-infra#9303

This PR was authored with an AI assistant (Claude Code).

pytorch/test-infra's trigger_nightly.yml cut the nightly branch of meta-pytorch/torchcomms with
GH_PYTORCHBOT_TOKEN, a classic personal access token that the meta-pytorch
org now rejects (403). The nightly branch has not moved since 2026-09-09, so
no nightly has been built from it. Pushing to it from here would also have to
get past the "Meta CLA Enforcement" ruleset, which a commit pushed without a
PR cannot satisfy.

Build main directly on a 11:30 UTC schedule instead. The reusable build
workflow uploads on trigger-event == schedule, so it does not need the nightly
branch. The `ref` input is set explicitly because it defaults to the nightly
branch. A new source-commit job writes the commit sha to the run summary so
each nightly can be traced to the commit it was built from. A manual run can
upload to the nightly index when `publish` is set: the workflow then reports
`schedule` as the trigger event to the reusable workflow. The wheel version
still comes from BUILD_VERSION, which the reusable workflow sets to
<version.txt>.dev<date> for the nightly channel.

Test Plan:

Not run on GitHub yet. After merge, dispatch the workflow to build and check
the summary and the build job's checkout. A workflow_dispatch without
`publish` builds main but does not upload; the first scheduled run (11:30 UTC)
is the end-to-end check. Tracking: pytorch/test-infra#9303

This PR was authored with an AI assistant (Claude Code).
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 9, 2026

@NicolasHug NicolasHug left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@d4l3k d4l3k left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants