[hyperactor] replace channel completion oneshots with receipts#4260
Open
mariusae wants to merge 1 commit into
Open
[hyperactor] replace channel completion oneshots with receipts#4260mariusae wants to merge 1 commit into
mariusae wants to merge 1 commit into
Conversation
This was referenced Jun 16, 2026
meta-cla
Bot
added
the
CLA Signed
mariusae
added a commit
that referenced
this pull request
Jun 16, 2026
Pull Request resolved: #4260 Replace the legacy `oneshot::Sender<SendError<M>>` completion adapter with `CompletionSink::receipt()`, backed by a small `CompletionSender` / `CompletionReceipt` pair whose accepted path stores a zero-payload state and wakes a single waiter while the rare rejected path stores the returned `SendError<M>`. Convert `Tx::try_post()` to return the receipt directly, simplify `send()` to await it, and update channel tests to assert `Ok(())` for accepted completions and `Err(SendError)` for rejected completions. ghstack-source-id: 393929686 @exported-using-ghexport Differential Revision: [D108622924](https://our.internmc.facebook.com/intern/diff/D108622924/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D108622924/)!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Replace the legacy
oneshot::Sender<SendError<M>>completion adapter withCompletionSink::receipt(), backed by a smallCompletionSender/CompletionReceiptpair whose accepted path stores a zero-payload state and wakes a single waiter while the rare rejected path stores the returnedSendError<M>. ConvertTx::try_post()to return the receipt directly, simplifysend()to await it, and update channel tests to assertOk(())for accepted completions andErr(SendError)for rejected completions.Differential Revision: D108622924
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!