Conversation
Member
|
Tests say:
Not sure if this is ready for review but just letting you know. |
Member
Author
|
@anmonteiro thanks for the heads up. took a while, but it seems now everything's good. |
jchavarri
commented
Oct 26, 2023
Comment on lines
+4
to
+6
| // ignoring these, are they are just temporary copies from runtime_deps, the final ones are in | ||
| // the path with melange.emit target, e.g. _build/default/dom/test/test/dom/test/__snapshots__ | ||
| modulePathIgnorePatterns: ["react/test/__snapshots__", "dom/test/__snapshots__"] |
anmonteiro
approved these changes
Oct 26, 2023
anmonteiro
left a comment
anmonteiro
left a comment
Member
There was a problem hiding this comment.
looks like a painful setup tbh
Member
Author
the bisect or the jest one? |
Member
|
The Bisect setup |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.