Skip to content

Tagged prod releases - #1058

Merged
lemald merged 5 commits into
masterfrom
lem-tagged-prod-releases
Jul 30, 2026
Merged

Tagged prod releases#1058
lemald merged 5 commits into
masterfrom
lem-tagged-prod-releases

Conversation

@lemald

@lemald lemald commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary of changes

Asana Ticket: Set up tag/release-based prod deploys - api

A couple of notes on this one:

  1. The previous deploy workflows were directly calling the relevant actions instead of making use of the deploy-ecs.yml workflow from the workflows repo. I decided to go ahead and change that.
  2. This repo has a regularly-scheduled daily deploy to dev-blue. I wanted to simply schedule that in deploy-lower-env.yml, but it sounds like you can't pass settings into cron-scheduled workflows. I ended up creating a separate workflow for this that shares the same concurrency group but is only ever triggered via cron. I hope that's all right?

@lemald
lemald force-pushed the lem-tagged-prod-releases branch 2 times, most recently from 1a75f65 to f665329 Compare July 29, 2026 17:41
@lemald
lemald marked this pull request as ready for review July 29, 2026 17:45
@lemald
lemald requested a review from a team as a code owner July 29, 2026 17:45
@lemald
lemald requested review from jzimbel-mbta and npatel-mbta and removed request for a team July 29, 2026 17:45
@lemald

lemald commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

@jzimbel-mbta looks like @npatel-mbta got auto-assigned, but tagging you specifically because of your familiarity with this stuff!

@jzimbel-mbta

Copy link
Copy Markdown
Member

1d15b0f is correct, that's another thing I wanted to go back and fix over in rtr. Good catch!

I thought I was being clever back when I wrote this—I wanted to reduce the amount of times checkout was called and thought that it could be called once and depended on by other jobs that needed the checked-out code, but each job runs in its own runner / container even if it depends on outputs of another job, so the checkout job I added is basically pointless. 😅

@jzimbel-mbta jzimbel-mbta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall. I tried coming up with a nicer way to configure the scheduled dev-blue deploys, but I think your approach is the least-janky option available.

Comment thread .github/workflows/deploy-lower-env.yml Outdated
Comment on lines +4 to +9
workflow_call:
inputs:
environment:
type: string
default: dev
required: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow isn't called by another* so the workflow_call block can be removed.

* (though maybe it would make sense for deploy-dev-blue-scheduled to call this one?)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd69bc3

I considered your parenthetical note, but decided that deploy-dev-blue-scheduled.yml is already so simple that there isn't much point in pointing it to deploy-lower-env,yml as far as I can tell.

@lemald
lemald merged commit 24dd2a1 into master Jul 30, 2026
13 checks passed
@lemald
lemald deleted the lem-tagged-prod-releases branch July 30, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants