Tagged prod releases - #1058
Conversation
1a75f65 to
f665329
Compare
|
@jzimbel-mbta looks like @npatel-mbta got auto-assigned, but tagging you specifically because of your familiarity with this stuff! |
|
1d15b0f is correct, that's another thing I wanted to go back and fix over in rtr. Good catch! I thought I was being clever back when I wrote this—I wanted to reduce the amount of times |
jzimbel-mbta
left a comment
There was a problem hiding this comment.
This looks good overall. I tried coming up with a nicer way to configure the scheduled dev-blue deploys, but I think your approach is the least-janky option available.
| workflow_call: | ||
| inputs: | ||
| environment: | ||
| type: string | ||
| default: dev | ||
| required: true |
There was a problem hiding this comment.
This workflow isn't called by another* so the workflow_call block can be removed.
* (though maybe it would make sense for deploy-dev-blue-scheduled to call this one?)
There was a problem hiding this comment.
I considered your parenthetical note, but decided that deploy-dev-blue-scheduled.yml is already so simple that there isn't much point in pointing it to deploy-lower-env,yml as far as I can tell.
Summary of changes
Asana Ticket: Set up tag/release-based prod deploys - api
A couple of notes on this one:
deploy-ecs.ymlworkflow from theworkflowsrepo. I decided to go ahead and change that.deploy-lower-env.yml, but it sounds like you can't pass settings intocron-scheduled workflows. I ended up creating a separate workflow for this that shares the same concurrency group but is only ever triggered viacron. I hope that's all right?