Skip to content

added a few lemmas about sup#1964

Merged
affeldt-aist merged 3 commits into
math-comp:masterfrom
holgerthies:sup_lemmas_20260511
May 21, 2026
Merged

added a few lemmas about sup#1964
affeldt-aist merged 3 commits into
math-comp:masterfrom
holgerthies:sup_lemmas_20260511

Conversation

@holgerthies
Copy link
Copy Markdown
Collaborator

Motivation for this change

Added a few Lemmas about sup to reals.v.
sup_ge0 is a specialization of ub_le_sup exploiting that sup is set to 0 if there is no supremum,
but it might be useful to shorten some proofs.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Merge policy

As a rule of thumb:

  • PRs with several commits that make sense individually and that
    all compile are preferentially merged into master.
  • PRs with disorganized commits are very likely to be squash-rebased.
Reminder to reviewers

@mkerjean
Copy link
Copy Markdown
Collaborator

Great, thank you for this pull request, it's very useful! I think the proofs can still be shortened a bit, I'll suggest changes as soon as possible.

Copy link
Copy Markdown
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! These lemmas are definitely useful. I have incorporated your comment about sup_ge0 into the script because it looks like a question that will easily spring to mind.

@affeldt-aist affeldt-aist force-pushed the sup_lemmas_20260511 branch from 975ded1 to d651577 Compare May 19, 2026 13:15
@affeldt-aist
Copy link
Copy Markdown
Member

I did some proof compression as @mkerjean suggested, so maybe we can merge.

@affeldt-aist affeldt-aist merged commit ad75dca into math-comp:master May 21, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants