added a few lemmas about sup#1964
Merged
Merged
Conversation
Collaborator
|
Great, thank you for this pull request, it's very useful! I think the proofs can still be shortened a bit, I'll suggest changes as soon as possible. |
affeldt-aist
approved these changes
May 19, 2026
Member
affeldt-aist
left a comment
There was a problem hiding this comment.
Thanks! These lemmas are definitely useful. I have incorporated your comment about sup_ge0 into the script because it looks like a question that will easily spring to mind.
975ded1 to
d651577
Compare
Member
|
I did some proof compression as @mkerjean suggested, so maybe we can merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added a few Lemmas about sup to reals.v.
sup_ge0is a specialization ofub_le_supexploiting thatsupis set to 0 if there is no supremum,but it might be useful to shorten some proofs.
Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers