fix: serve duplicate transaction submissions the original's status - #46
Draft
bmuddha wants to merge 1 commit into
Draft
fix: serve duplicate transaction submissions the original's status#46bmuddha wants to merge 1 commit into
bmuddha wants to merge 1 commit into
Conversation
A transaction submitted twice was deduplicated correctly but its second submitter was never told the outcome, so it blocked until its own deadline and reported a timeout for a transaction that had succeeded. `Sequencer::schedule` returned silently when `append` reported a duplicate. That is harmless while the original is still in flight — both submitters share the signature's channel and `commit_execution` reaches both — but once the original settles, the terminal broadcast takes that channel with it, and a duplicate arriving afterwards subscribes to a fresh one nothing will ever write to. `commit_execution` also cached the status *after* that broadcast, leaving a window in which a late subscriber found neither a live channel nor a cached result. Reached from ordinary validator behaviour: chainlink's dependency refresh issued two identical clone transactions 0.8ms apart, which share a signature. The clone landed successfully; its caller still saw `deadline has elapsed` 8s later and undelegated the account. - add `TransactionsAccessor::notify_duplicate`, replaying the cached status to the signature's subscribers. A cached `None` means still in flight, where the shared channel already serves both, so it correctly does nothing. - call it from `Sequencer::schedule` on the duplicate path. - cache before broadcasting, closing the ordering window. Refs #41 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #ISSUE
Impact
Validation
Reviewer notes