Repository navigation
fix(channels): keep ringing pins joinable and size pins like iMessage - #8612
Merged
Merged
Conversation
Why: The mobile Channels list used its own row sizing and a full-width divider that looked worse than Home, and favorites had no quick access. What: Render mobile Channels rows with Home's touch row (unread rail, avatar column, inset divider) and pin the first six channel favorites in an iMessage-style grid above the feed, removing them from the list below.
A pinned conversation with an incoming call stays in the list so its Join and Decline actions remain reachable. Feed rows keep Home's focusable root, and pins show a focus ring.
Larger borderless avatars with the unread dot on the avatar's corner, a smaller muted name, and a short last row centered.
…-home-rows # Conflicts: # apps/web/src/features/channels-view/components/ChannelPins.tsx # apps/web/src/features/channels-view/components/ChannelsMobileView.test.tsx # apps/web/src/features/channels-view/components/ChannelsMobileView.tsx
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 3
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jbecke
enabled auto-merge (squash)
October 23, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#8611 auto-merged before its last two commits were pushed, so main is missing them:
What
ChannelsMobileView.tsx: a pinned conversation stays in the feed while its call rings, soIncomingCallActionsstays reachable. Activity is computed over pins plus the full source list so that this filter can read incoming calls. Removedfocusable={false}, so feed rows keep Home's focusable root.ChannelPins.tsx:focus-visiblering.ChannelsMobileView.test.tsx: regression test that a ringing pinned channel keeps its feed row and Join action.Generated by Claude Code