Skip to content

6.2.3: chart hover during events (#137) and parallel remote log prefixes (#128) - #144

Merged
m4r1k merged 6 commits into
mainfrom
fix/6.2.3-remote-logs-and-chart-hover
Nov 13, 2026
Merged

m4r1k merged 6 commits into
mainfrom
fix/6.2.3-remote-logs-and-chart-hover

Conversation

@m4r1k

@m4r1k m4r1k commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

This PR prepares the 6.2.3 point release with two bug fixes reported by @ckrevel.

1. Keep chart metric hover active across outage bands and event pins (Refs #137)

Think of the chart hover rectangle (.chart-hit) as a pane of glass over the plot that tracks your cursor, moves the crosshair, and reads out the metric value. Previously we taped the red outage shading (.outage-band) and event pins (.ev-marker) on top of that glass with their own mouse listeners. Whenever the cursor crossed into an outage window or touched a marker column, those stickers caught the mouse event instead, freezing the crosshair and top-right live readout and hiding the actual voltage/charge/power reading.

  • Make .outage-band and .ev-marker pointer-events: none and wire .chart-hit above them on Power, Battery, and Energy charts so the crosshair, highlight dot, top-right readout, and metric value stay live across the entire plot area (and honor padR = 40 on dual-axis Energy charts so .chart-hit stops at the right-axis margin).
  • Hit-test cursor X against active outage spans and tier-1 event marker columns (5.5px radius, matching the 11px visual guide width), highlight any matched marker via .is-hover, and append the matched event and/or outage details below a .tip-sep divider inside the same floating tooltip.
  • Keep tabindex="0", role="img", aria-label, and bindTip focus/blur handlers intact on .ev-marker and .outage-band for keyboard Tab navigation.

2. Tag per-step remote shutdown logs with the server name (Refs #128)

Picture two chefs calling out "step 1 done!" and "sending final order!" from the kitchen at the same time without saying which table's ticket they're working on. During parallel remote shutdown batches (parallel: true or shared shutdown_order), the opening and closing lines named the server, while every intermediate pre-shutdown step, Sending shutdown command, and [DRY-RUN] line interleaved anonymously.

  • Prefix every per-step remote and host-loopback shutdown line in src/eneru/shutdown/remote.py with [<name>] (falling back to [<host>]), placed after the leading indent + emoji so JSONFormatter's column-0 [Group] split and all existing unit/E2E substring assertions stay intact.
  • Name the unfinished server(s) directly in _shutdown_servers_parallel's phase-timeout warning.

3. Release bump (6.2.3)

  • Bump src/eneru/version.py to 6.2.3 and move [Unreleased] into ## [6.2.3] - 2026-11-13 in docs/changelog.md.

Verification

  • Full unit suite: 4921 passed, 3 skipped, all 49 files under src/eneru/ ≥ 95% line+branch coverage (97.80% total).
  • Node-backed harness in tests/test_dashboard.py exercising real appendOutageBands, appendEventMarker, bindTip, and addChartHover (outside outage, inside outage band, over marker column, over null-valued gap sample, mouseleave, and keyboard focus/blur), plus tools/dashboard-preview.py visual audit in light and dark themes across Power, Battery, and Energy tabs.
  • eneru validate on examples/config-reference.yaml and mkdocs build --strict.
  • Independent pre-push review subagent (research subagent, inherited parent runtime model): 0 P0, 0 P1; 2 P2s (changelog wording precision and exercising real overlay builders in test_dashboard.py) and 1 P3 (.ev-hit comment alignment) addressed prior to push.

Summary by CodeRabbit

  • Bug Fixes
    • Chart tooltips now show nearby outage and event details alongside metric readings, with improved marker highlighting and keyboard focus support.
    • Remote shutdown messages identify the relevant server or host, and timeout warnings list servers that are still running.
  • Compatibility
    • Added support for Python 3.15, including required CI validation.
  • Documentation
    • Updated the release notes and dashboard testing guidance.

Two cooks calling out 'timer started!' in the same kitchen tell you nothing unless each one names their station. When two or more remote servers shut down in parallel, their worker threads interleave line by line, so intermediate step lines ('Executing N pre-shutdown command(s)', '[idx/N] ...', and 'Sending shutdown command') could not be matched back to the 'Initiating remote shutdown' header above them.

- Prefix every per-server intermediate log line in _execute_remote_pre_shutdown, _shutdown_remote_server, and _shutdown_loopback_command with [display_name] (falling back to server.host when name is unset).

- Name any unfinished server(s) in the 'remote shutdown(s) still in progress' phase-timeout warning.
…#137)

Think of a sheet of clear glass laid over a map with pins and shaded storm zones. Previously, outage bands (.outage-band) and event marker columns (.ev-marker) were appended above the chart hover capture rect (.chart-hit) with their own pointer listeners, like opaque stickers pasted on top of the glass: moving the cursor into any outage band fired mouseleave on .chart-hit, hid the crosshair and live readout, and showed only the static outage or event tooltip.

- Make .outage-band and .ev-marker pointer-events: none and place .chart-hit above them so pointer hover tracks metric samples continuously across Power, Battery, and Energy charts (preserving Tab focus/blur tooltips on both elements for keyboard users).

- Hit-test nearby event markers (5.5px) and active outage spans inside addChartHover, highlight the hovered marker guide (.is-hover), and append matched event/outage details below a divider in the same tooltip.

- Honor dual-axis right padding (padR) on .chart-hit width in drawEnergyChart.
Bumps version.py to 6.2.3 and moves [Unreleased] into the 6.2.3
changelog entry covering #128 and #137.
Runs appendOutageBands, appendEventMarker, and bindTip directly inside
the Node chart-hover harness (including keyboard focus/blur and SVG
paint order) and aligns the .ev-hit comments with pointer-events: none.
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The 6.2.3 changes update dashboard chart hover behavior, add server and host details to remote shutdown logs, and update release notes and versioning.

Changes: Dashboard chart hover

Layer / File(s) Summary
Overlay matching and tooltip composition
src/eneru/web/app.js
Chart hover matches nearby event markers and covering outage spans. Tooltips combine overlay details with available metric values and timestamps.
Chart wiring and hover validation
src/eneru/web/app.js, src/eneru/web/style.css, tests/test_dashboard.py, docs/testing.md, docs/changelog.md
Metric and energy charts pass marker and outage geometry to hover handling. Styling supports hover and keyboard focus. Regression tests cover overlays, gaps, and hover clearing. The release notes describe chart-hover behavior. The dashboard test-area row remains unchanged.
Shutdown test documentation
docs/testing.md
The Shutdown mixins test-area row remains unchanged.

Remote shutdown logging

Layer / File(s) Summary
Server labels and shutdown log coverage
src/eneru/shutdown/remote.py, tests/test_remote_commands.py, docs/changelog.md, src/eneru/version.py
Shutdown logs identify the relevant server or host, and phase-timeout warnings list servers still running. Tests cover server prefixes and host fallback. The release notes document these changes, and the version changes to 6.2.3.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant ChartRenderer
  participant addChartHover
  participant Pointer
  participant Tooltip
  ChartRenderer->>addChartHover: pass marker and outage geometry
  Pointer->>addChartHover: provide pointer position
  addChartHover->>Tooltip: show sample and matched overlay details
Loading
Merge Risk: Minimal · previous review bdae7

This release changes chart hover behavior in the dashboard and adds server names to parallel remote shutdown log lines. No concrete merge-blocking risk was identified. Dashboard and shutdown behavior beyond what the tests cover was not reproduced independently.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names two changes in the PR: chart hover behavior during outage and event overlays (#137), and server-name log prefixes for parallel remote shutdown steps (#128), plus the 6.2.3 version bump…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names two changes in the PR: chart hover behavior during outage and event overlays (#137), and server-name log prefixes for parallel remote shutdown steps (#128), plus the 6.2.3 version bump. The changeset contains all three. The title covers the two bug fixes but does not mention the Python 3.15 support also listed in the changelog, which is a secondary change. The title is specific and related to the main changes, so it passes.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a78cf67 and bdae7ed.

Files selected for processing: 8

  • docs/changelog.md
  • docs/testing.md
  • src/eneru/shutdown/remote.py
  • src/eneru/version.py
  • src/eneru/web/app.js
  • src/eneru/web/style.css
  • tests/test_dashboard.py
  • tests/test_remote_commands.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

@codecov

codecov Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.48%. Comparing base (a78cf67) to head (f828d72).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   98.48%   98.48%   -0.01%     
==========================================
  Files          45       45              
  Lines       18433    18433              
  Branches     3800     3800              
==========================================
- Hits        18154    18153       -1     
- Misses        279      280       +1     
Files with missing lines Coverage Δ
src/eneru/shutdown/remote.py 98.60% <100.00%> (-0.24%) ⬇️
src/eneru/version.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m4r1k

m4r1k commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Action performed

Full review finished.

@m4r1k

m4r1k commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

@cubic-dev-ai review this pull request

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

@cubic-dev-ai review this pull request

@m4r1k I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 8 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread docs/changelog.md Resolved
Comment thread tests/test_dashboard.py Resolved
m4r1k and others added 2 commits November 13, 2026 13:45
Narrows the 6.2.3 parallel-remote changelog sentence to previously
unlabeled per-step lines and attaches the crosshair group to svg in the
Node hover harness so final SVG paint order is verified too.
- Drop the duplicated server name from the per-command dry-run line
  ("[nas] [DRY-RUN] Would execute on nas" -> "[nas] [DRY-RUN] Would execute").
- Assert the phase-timeout warning actually names the unfinished server.
- Remove .graph g:hover marker selectors: markers are pointer-events: none
  since #137, so only .is-hover and :focus can highlight them.

Co-authored-by: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@m4r1k
m4r1k merged commit 781ca7a into main Nov 13, 2026
40 checks passed
@m4r1k
m4r1k deleted the fix/6.2.3-remote-logs-and-chart-hover branch November 13, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant