[dbnode] - Add filesystem available space reporting#3450
Open
shrek wants to merge 5 commits into
Open
Conversation
Currently, there are no metrics reporting on the amount of space available in the filesystem directory path used by the dbnode. Add a reporter which reports on the available space. This metric could be used for alerting purposes if the available space crosses thresholds. Example metrics reported: filesystem_avail_bytes 4.3406266368e+10 filesystem_num_api_errors 0 filesystem_total_bytes 6.2725623808e+10 Which matches with the output of df 1K-blocks Used Available 61255492 15725236 42388932
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3450 +/- ##
=========================================
- Coverage 72.4% 64.4% -8.0%
=========================================
Files 1100 1100
Lines 102443 101703 -740
=========================================
- Hits 74203 65579 -8624
- Misses 23143 31312 +8169
+ Partials 5097 4812 -285
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes #3400
Please refer to the discussion in the issue. In summary, this PR adds metrics
for available space in the filesystem, and the sizes of files in different m3db
directories. It can be used to alert on filesystem available space thresholds.
The added metrics look like this:
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: