Skip to content
This repository was archived by the owner on Jan 18, 2026. It is now read-only.

Refactor widgets creation, add smaller methods#2730

Open
mmalczak wants to merge 1 commit into
m-labs:masterfrom
elhep:refactor_experiment_widgets_qt6
Open

Refactor widgets creation, add smaller methods#2730
mmalczak wants to merge 1 commit into
m-labs:masterfrom
elhep:refactor_experiment_widgets_qt6

Conversation

@mmalczak

Copy link
Copy Markdown

ARTIQ Pull Request

Description of Changes

Create experiment widgets in separate methods.

Related Issue

Type of Changes

Type
🔨 Refactoring

Steps (Choose relevant, delete irrelevant before submitting)

All Pull Requests

  • Use correct spelling and grammar.
  • Check the copyright situation of your changes and sign off your patches (git commit --signoff, see copyright).

Code Changes

  • Run flake8 to check code style (follow PEP-8 style). flake8 has issues with parsing Migen/gateware code, ignore as necessary.
  • Test your changes or have someone test them. Mention what was tested and how.

Licensing

See copyright & licensing for more info.
ARTIQ files that do not contain a license header are copyrighted by M-Labs Limited and are licensed under LGPLv3+.

Signed-off-by: Miłosz Malczak <milosz.malczak@gmail.com>
@mmalczak mmalczak mentioned this pull request Apr 18, 2025
8 tasks
@SimonRenblad

Copy link
Copy Markdown
Contributor

Instead of separate functions for each type of setting, perhaps separate out the scheduler settings as a whole and leave the bottom two buttons as is? This would probably help simplify logic in #2724. I don't think "having smaller methods" on it's own is a sufficient reason to move things around.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants