Repository navigation
Fix document replacement, watcher synchronization, and search weighting - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-importing, moving, or emptying a document could leave obsolete chunks and orphaned visual captions in search results. This change replaces each source atomically, gives all chunks the same resolved source identity and page numbering, and reconciles file changes when the watcher starts.
The fixes also preserve documents during metadata migration and failed extraction/embedding, use an OS lock for watcher ownership, refresh database readers across processes, apply
search_alphato weighted rank fusion, and load complete cached embedding snapshots directly. Windows output uses UTF-8, including help output; an explicit new config path no longer falls back to the user's existing config. Source-filtered queries retain the configured search weighting. LanceDB's minimum version is raised to 0.25 for native full-text indexing.Validation on Windows / Python 3.11:
The original polling watcher is covered by a new isolated regression test. Live OCR/VLM quality and OS autostart installation were not exercised. README documents cleanup of ambiguous relative/basename source entries left by older releases; these cannot all be safely reassigned automatically.