Keep gain map source alive during pipeline processing - #4599
Open
gregbenz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With caching disabled, .keepGainMap().rotate(90).toBuffer() can report “Not a JPEG file” even when the input is a valid gain-map JPEG. The gain map still needs data from the source image, but that data may be freed before decoding finishes. This fix keeps the source alive until processing is done.
This PR adds 2 production statements and a regression test. The test fails without the fix and passes with it, checking the rotated dimensions and decoding the output gain map. All 1,828 unit tests pass on M5 MBP. Lint and type checks also pass, with a quoted test glob and a temporary npm cache needed for the local checks.