Fix: overlapping whisper timestamps cause subtitle flicker#3
Open
Fahad-200 wants to merge 1 commit into
Open
Conversation
When Whisper produces overlapping word timestamps (word B starts before word A ends), the old fallback of seg_start + 0.05s created a visible flash. Now uses the word's own whisper-reported end time, with a 0.3s minimum floor. Non-overlapping words are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Whisper produces overlapping word timestamps (i.e. the next word starts before the current word ends), line 57 falls back to
seg_end = seg_start + 0.05. A 0.05s display window is ~1.5 frames at 30fps — the word barely renders, causing a visible white flash.Fix
Changed the fallback to
max(w["end"], seg_start + 0.3). This uses the word's own whisper-reported end time (more accurate), with a 0.3s minimum floor (~9 frames) if even that is malformed. Non-overlapping words are completely unaffected — they never enter this branch.Before vs After