Match Trio's override/temp-target colors for non-Loop backends#668
Open
bjorkert wants to merge 1 commit into
Open
Match Trio's override/temp-target colors for non-Loop backends#668bjorkert wants to merge 1 commit into
bjorkert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overrides and temp targets were drawn with the colors swapped relative to Trio. In Trio an override is purple and a temp target is green; LoopFollow had them reversed.
Now non-Loop backends (Trio, OpenAPS) follow Trio's scheme — override purple, temp target green — while Loop keeps its existing colors (override green, temp target purple). The choice keys off the existing
device == "Loop"convention, so it reacts to a backend change without recreating the graph.Also switches the override info-row population in
Overrides.swiftfrom== "Trio"to!= "Loop"so it applies to all non-Loop backends.