Conversation
- Change root overflow from hidden to clip to allow sticky children to escape - Make header sticky at top so copy button stays visible when scrolling long code - Add container background to header for proper sticky rendering Fixes lobehub/lobehub#6764 Fixes lobehub/lobehub#7129
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
馃挕 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0c53909a5
鈩癸笍 About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 馃憤.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| position: sticky; | ||
| top: 0; | ||
| z-index: 3; |
There was a problem hiding this comment.
Add opaque background to all sticky header variants
Making headerRoot sticky applies to every highlighter variant, but only headerFilled now gets an explicit background. In fullFeatured mode with variant="outlined" or variant="borderless", scrolling long code blocks causes code text to move underneath a transparent sticky header, which reduces readability and can make action buttons hard to see. Since this behavior is introduced by the new sticky positioning, the header should use an opaque background for the non-filled variants as well.
Useful? React with 馃憤聽/ 馃憥.
Summary
overflow: hiddentooverflow: clipto allow sticky-positioned children to escape the clipping containerposition: sticky; top: 0so the copy button stays visible when scrolling through long code blocksRelated
Test plan