Skip to content

feat(hf): publish recovery_report.json alongside the network #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AlexanderFengler wants to merge 1 commit into from
Closed

feat(hf): publish recovery_report.json alongside the network #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/lanfactory/hf/upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
"*_config.pickle",
"*_data_details.pickle",
"validation_report.json",
# The gate report says the network is structurally sound; this one says
# whether anyone could recover parameters with it. Without it the only
# quality evidence that travels with an artifact is the gate, which cannot
# see a recovery failure at all.
"recovery_report.json",
"*.csv",
"model_card.yaml",
]
Expand Down
4 changes: 4 additions & 0 deletions tests/hf/test_dual_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ def model_folder(tmp_path):
(folder / "abc123_lan_ddm__network_config.pickle").write_bytes(b"pickle")
(folder / "abc123_lan_ddm__data_details.pickle").write_bytes(b"pickle")
(folder / "validation_report.json").write_text('{"gates": {}}')
(folder / "recovery_report.json").write_text('{"passed": false}')
(folder / "abc123_lan_ddm__training_history.csv").write_text("epoch,loss\n")
return folder

Expand Down Expand Up @@ -344,6 +345,9 @@ def test_new_artifacts_are_included(self, model_folder, capsys):
out = capsys.readouterr().out
assert "abc123_lan_ddm__data_details.pickle" in out
assert "validation_report.json" in out
# The gate report cannot see a recovery failure; a network whose
# recovery verdict is false would otherwise ship looking clean.
assert "recovery_report.json" in out


class TestUploadCommit:
Expand Down
Loading