feat(kart-import): Add the config and fixups for carto_text. BM-1868 - #393
Open
Wentao-Kuang wants to merge 10 commits into
Open
Wentao-Kuang wants to merge 10 commits into
Wentao-Kuang wants to merge 10 commits into
Conversation
Wentao-Kuang
force-pushed
the
feat/import-carto-text-config
branch
from
September 15, 2026 02:35
acf206d to
ba362cd
Compare
Wentao-Kuang
marked this pull request as ready for review
September 15, 2026 02:48
blacha
reviewed
Sep 15, 2026
blacha
reviewed
Sep 15, 2026
blacha
reviewed
Sep 15, 2026
blacha
reviewed
Sep 15, 2026
Wentao-Kuang
force-pushed
the
feat/import-carto-text-config
branch
from
September 17, 2026 03:12
a1b3ad1 to
ea38af2
Compare
ccbblin
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds the kart-import config and fixups for importing
nztopo50_carto_text. Reimplement the fixups from LAMBS carto-text import and example-point-id fixupsModifications
Theme config (config/themes/nztopo50_carto_text.yml): maps the raw linz_carto_text source fields and wires up the two fixups below.
carto_text_styling fixup: using carto_text_styling.csv to decode and mapping the style fields and populate into the output data. carto_text_styling.csv files is simplified csv file from the original mapping sheet , which is easier for processing.
carto_text_example_point_id fixup: links each map-sheet example label to its example point with the following two steps:
Verification
Unit test, and data pushed into linz/topographic-product-data-dev#1 for review.