feat: update various config theme files (batch d) BM-1860 - #387
tawera-manaena wants to merge 10 commits into
Conversation
|
Issues geom must be called-> geometry type and subtype values with spaces should have underscore _ tank_type: surge chamber = surge_chamber water subtype:must be equal to one of the allowed values |
|
One missed is to fix typo in structure_point: watre = water Some more complex rules for structures |
|
water |
|
We need to check we are not losing data in this field gazfeatid -> feat_id = should end up as metadata - ids associated with names in lookup. - WATER_LINE - note this is similar to road_line metadata. 'table_column', 'name', |
|
Final element: |
55bded8 to
0017fb4
Compare
The merge-base changed after approval.
a7ab298 to
daa53c1
Compare
daa53c1 to
997b958
Compare
997b958 to
1068a7f
Compare
Motivation
To import a layer via the kart-import package, we define a config theme file that maps the source data to our target schema. Each theme file must conform to the latest schema version.
Our existing theme files were written against an earlier version of the schemas and do not yet conform to the updated v0.3 definitions. This pull request updates a set of those theme files so their mappings align with the v0.3 schemas, allowing us to import their datasets.
Modifications
Disabled all datasets besides those for NZ Mainland and Chatham Islands.
packages/kart-import/config/themes/
Added and updated the following config theme files:
structure.ymlstructure_line.ymlstructure_point.ymlvegetation.ymlwater.ymlwater_line.ymlUpdated dataset mappings to conform to their respective v0.3 schemas.
Verification
Tested locally using the following commands to ensure the updated theme files fufill their schemas:
Note: The
KART_SCHEMA_CHECKflag checks everything, rather than just the specified theme. But, it's very useful for finding out which attributes you might be missing in your theme file.