NotificationDaemon, messageTray: Add inline reply support for notifications - #13907
Open
Twilight0 wants to merge 1 commit into
Open
NotificationDaemon, messageTray: Add inline reply support for notifications#13907Twilight0 wants to merge 1 commit into
Twilight0 wants to merge 1 commit into
Conversation
Best-practices scannerThis is a regex-based check for API usage that can pose security, performance or This check is not perfect and will not replace a normal review.Found 1 potential issue(s):
|
…ations
This commit adds native support for inline reply text input boxes inside Cinnamon
desktop notifications (org.freedesktop.Notifications).
Key Enhancements:
1. Notification Daemon Capabilities & Hints (js/ui/notificationDaemon.js):
- Exposes 'inline-reply' and 'x-canonical-private-inline-reply' in GetCapabilities().
- Parses inline reply hints ('x-canonical-private-inline-reply' and 'inline-reply') from incoming D-Bus Notify calls.
- Registers and emits the NotificationReplied(uint32 id, string text) D-Bus signal when a user submits a reply.
- Renders explicit 'Reply' action buttons on the banner, expanding the text input field on demand when clicked, while preserving all other action buttons (e.g. 'Like', 'Mark as Read').
2. UI & Focus Management (js/ui/messageTray.js):
- Renders an St.Entry input field and Send St.Button in NotificationBanner when an inline reply hint is present or when the Reply action button is clicked.
- Acquires a modal keyboard grab via Main.pushModal() on entry focus/interaction so typing events are routed to Cinnamon's stage rather than underlying application windows.
- Releases the modal keyboard grab (Main.popModal()) on reply submission or notification destruction.
- Connects both Return key press (clutter_text activate) and Send button clicks to emit the reply text and dismiss the notification popup.
Twilight0
force-pushed
the
feat/inline-reply-notifications
branch
from
July 28, 2026 22:51
bcb4e74 to
69a97ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds native support for inline reply text input boxes inside Cinnamon desktop notifications (org.freedesktop.Notifications).
Key Enhancements:
Notification Daemon Capabilities & Hints (js/ui/notificationDaemon.js):
UI & Focus Management (js/ui/messageTray.js):