Repository navigation
Close TUI nodes for failed tool calls; accept stringified knowledge tags - #88
Merged
Merged
Conversation
A tool that raises (e.g. argument validation fails) emits on_tool_error
instead of on_tool_end. The TUI only handled on_tool_end, so the node spun
"in progress" forever and the active-tool count stayed high. Handle both.
GLM sometimes sends tags as one string ("['a', 'b']"), which failed
list[str] validation and forced a resend: 9 failed save_knowledge calls
across the last few runs. The knowledge tools now coerce such strings into a
list before validation; the advertised schema is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tool that raises (e.g. argument validation fails) emits on_tool_error instead of on_tool_end. The TUI only handled on_tool_end, so the node spun "in progress" forever and the active-tool count stayed high. Handle both.
GLM sometimes sends tags as one string ("['a', 'b']"), which failed list[str] validation and forced a resend: 9 failed save_knowledge calls across the last few runs. The knowledge tools now coerce such strings into a list before validation; the advertised schema is unchanged.