Skip to content

Close TUI nodes for failed tool calls; accept stringified knowledge tags - #88

Merged
linted merged 1 commit into
mainfrom
worktree-tool-error-and-tags
Nov 19, 2026
Merged

linted merged 1 commit into
mainfrom
worktree-tool-error-and-tags

Conversation

@linted

@linted linted commented Nov 19, 2026

Copy link
Copy Markdown
Owner

A tool that raises (e.g. argument validation fails) emits on_tool_error instead of on_tool_end. The TUI only handled on_tool_end, so the node spun "in progress" forever and the active-tool count stayed high. Handle both.

GLM sometimes sends tags as one string ("['a', 'b']"), which failed list[str] validation and forced a resend: 9 failed save_knowledge calls across the last few runs. The knowledge tools now coerce such strings into a list before validation; the advertised schema is unchanged.

A tool that raises (e.g. argument validation fails) emits on_tool_error
instead of on_tool_end. The TUI only handled on_tool_end, so the node spun
"in progress" forever and the active-tool count stayed high. Handle both.

GLM sometimes sends tags as one string ("['a', 'b']"), which failed
list[str] validation and forced a resend: 9 failed save_knowledge calls
across the last few runs. The knowledge tools now coerce such strings into a
list before validation; the advertised schema is unchanged.
@linted
linted merged commit 1d1b65e into main Nov 19, 2026
2 checks passed
@linted
linted deleted the worktree-tool-error-and-tags branch November 19, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant