Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions src/ghidra_deep_agent/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

from langchain_core.embeddings import Embeddings
from langchain_core.language_models import BaseChatModel
from langchain_core.messages import AIMessage, AIMessageChunk
from langchain_core.messages import AIMessage, AIMessageChunk, HumanMessage
from langchain_core.messages.ai import UsageMetadata, subtract_usage
from langchain_core.outputs import ChatGenerationChunk
from langchain_deepseek import ChatDeepSeek
Expand All @@ -24,6 +24,11 @@ class _ChatDeepSeekFixed(ChatDeepSeek):
include the original reasoning_content on subsequent turns. The base
langchain_deepseek package stores it in additional_kwargs but never writes
it back into the request payload, causing a 400 on multi-turn sessions.

Only the current turn (assistant messages after the latest human message)
gets its reasoning back: the model needs it between tool calls, but
finished turns' reasoning is dead weight. One resumed GLM-5.3 session was
sending ~124k chars of it, about half of every request.
"""

def _get_request_payload(
Expand All @@ -32,9 +37,17 @@ def _get_request_payload(
original_messages = self._convert_input(input_).to_messages()
payload = super()._get_request_payload(input_, stop=stop, **kwargs)

turn_start = max(
(
i
for i, msg in enumerate(original_messages)
if isinstance(msg, HumanMessage)
),
default=-1,
)
reasoning_iter = (
msg.additional_kwargs.get("reasoning_content")
for msg in original_messages
msg.additional_kwargs.get("reasoning_content") if i > turn_start else None
for i, msg in enumerate(original_messages)
if isinstance(msg, AIMessage)
)
for message in payload.get("messages", []):
Expand Down
29 changes: 28 additions & 1 deletion tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,12 @@

import pytest
from langchain_anthropic import ChatAnthropic
from langchain_core.messages import AIMessageChunk, HumanMessage
from langchain_core.messages import (
AIMessage,
AIMessageChunk,
HumanMessage,
ToolMessage,
)
from langchain_core.outputs import ChatGenerationChunk
from langchain_openai import ChatOpenAI

Expand Down Expand Up @@ -243,6 +248,28 @@ def test_opencode_responses_models_take_reasoning_effort() -> None:
assert getattr(model, "reasoning_effort") == "low" # noqa: B009


def test_only_the_current_turn_round_trips_reasoning() -> None:
model = build_model("opencode-go:glm-5.3")
assert isinstance(model, _ChatDeepSeekFixed)
messages = [
HumanMessage("first question"),
AIMessage("answer", additional_kwargs={"reasoning_content": "old"}),
HumanMessage("second question"),
AIMessage(
"",
tool_calls=[{"name": "t", "args": {}, "id": "c1"}],
additional_kwargs={"reasoning_content": "current"},
),
ToolMessage("result", tool_call_id="c1"),
]
assistant = [
m
for m in model._get_request_payload(messages)["messages"]
if m["role"] == "assistant"
]
assert [m.get("reasoning_content") for m in assistant] == [None, "current"]


@pytest.mark.parametrize(
"spec", ["opencode:claude-sonnet-4-6", "deepseek:deepseek-v4-pro", "zai:glm-5.2"]
)
Expand Down
Loading