feat: call logout endpoint for dex - #852
Open
CasLubbers wants to merge 1 commit into
Open
CasLubbers wants to merge 1 commit into
CasLubbers wants to merge 1 commit into
Conversation
Signed-off-by: Cas Lubbers <clubbers@akamai.com>
CasLubbers
requested review from
dennisvankekem and
ferruhcihan
as code owners
October 2, 2026 08:40
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The global 401 interceptor can prevent the Dex logout redirect and send users back through login.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds backend logout handling before redirecting users to Dex logout.
Changes:
- Adds the
/v2/user/logoutmutation. - Calls logout before redirecting.
- Adds logout-flow tests.
| File | Description |
|---|---|
src/redux/otomiApi.ts |
Exposes the logout endpoint and hook. |
src/pages/Logout.tsx |
Calls the endpoint before redirecting. |
src/pages/Logout.test.tsx |
Tests success, failure, and fetch-error flows. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| useEffect(() => { | ||
| if (fetchError) window.location.reload() | ||
| else window.location.href = '/platform-logout' | ||
| else logout().finally(() => window.location.assign('/platform-logout')) |
This was referenced Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with: