chore: remove AplUser from file map and remove unused code

[merll]

No description provided.

[Copilot]

🟡 Changes recommended

There are concrete correctness/CI-risk issues in updated code/comments (notably an unused test helper parameter likely to fail lint/TS settings) that should be fixed before approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR removes the legacy AplUser kind from the platform file-mapping system and cleans up related code paths/tests, aligning user persistence with the namespace-scoped SealedSecret flow used elsewhere in the stack.

Changes:

• Removed AplUser from the supported kind list and deleted its file-map entry (env/users/*.yaml).
• Deleted the deleteUserFile() helper that relied on the removed AplUser file-map.
• Updated tests and comments to stop seeding/expecting AplUser resources in the FileStore.

File summaries

File	Description
src/otomi-stack.ts	Removes the legacy deleteUserFile() helper tied to AplUser file paths.
src/otomi-stack.test.ts	Stops creating AplUser resources in FileStore when setting up users in tests.
src/otomi-models.ts	Drops AplUser from APL_KINDS, removing it from the valid kind union.
src/fileStore/file-store.ts	Updates comment to remove AplUser reference for platform resources.
src/fileStore/file-map.ts	Deletes the AplUser file-map entry (env/users/{name}.yaml).
src/fileStore/file-map.test.ts	Removes the getResourceFilePath('AplUser', ...) test case.

Review details

• Files reviewed: 6/6 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

🔵 Needs a closer look

The updated test helper now has an unused parameter and misleading helper header, which can fail lint/unused-parameter checks and should be corrected.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🟢 Approval recommended

The AplUser kind and its legacy file-map usage are fully removed without remaining references, and user CRUD continues to operate via SealedSecret manifests.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Update the unused otomiStack test-helper parameter, its callers, and the misleading FileStore-based documentation.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Remove or rename the unused otomiStack parameter in src/otomi-stack.test.ts.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Rename or remove the now-unused otomiStack parameter in src/otomi-stack.test.ts.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🔵 Needs a closer look

Address the unused otomiStack parameter causing a lint warning.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…

[Copilot]

Copilot review overview

🔵 Needs a closer look

The unused otomiStack parameter in src/otomi-stack.test.ts should be removed or renamed.

Review effort: Lite
Findings: 1 · 1

Open (2)

• The comment says the user SealedSecret manifest is stored in the FileStore to keep it in sync with…
• createTestUser no longer uses the otomiStack parameter, which can trigger TypeScript/eslint…