webapi: don't upgrade custom elements in a windowless document - #3409
Open
karlseguin wants to merge 1 commit into
Open
webapi: don't upgrade custom elements in a windowless document#3409karlseguin wants to merge 1 commit into
karlseguin wants to merge 1 commit into
Conversation
A custom element created in a windowless document (think DOMParser, or new Document(), ...) doesn't have a custom element registry and thus should remain undefined. This repurposes the existing Frame._skip_custom_element_upgrade boolean into a tri-state enum to capture the 3 possible states: `construct` and `bare_context` capture the previous boolean state, and `undefined` is now used for this third state. This fixes (non-fatal) errors on decathlon.com. It also fixes a few WPT cases and advances a few more (which are now failing for a different reason).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom element created in a windowless document (think DOMParser, or new Document(), ...) doesn't have a custom element registry and thus should remain undefined.
This repurposes the existing Frame._skip_custom_element_upgrade boolean into a tri-state enum to capture the 3 possible states:
constructandbare_contextcapture the previous boolean state, andundefinedis now used for this third state.This fixes (non-fatal) errors on decathlon.com. It also fixes a few WPT cases and advances a few more (which are now failing for a different reason).