chore: leverage bridge for error rejection - #3403
Open
karlseguin wants to merge 1 commit into
Open
Conversation
#3095 made the bridge more promise- aware. A WebAPI with a `!js.Promise` return type that returns an error will not reject the promise. That PR was limited to Crypto. This expands it where possible. Generally speaking, the result is just more idiomatic Zig code. From: ```zig validateName(name) catch |err| switch (err) { error.SyntaxError => return local.rejectPromise(.{ .dom_exception = .{ .err = error.SyntaxError } }), } ``` to: ```zig try validateName(name); ``` However, because TypeErrors must often reject with a specific message, we use a pseudo-global in Env. So, you'd do: ```zig .invalid => return local.typeError("invalid algorithm"), ``` which return error.TypeError AND stores "invalid algorithm" on the `Env`. When `Caller` gets `error.TypeError` it checks the Env for a message. Who says Zig errors can't carry payloads?! ;# Please enter the commit message for your changes. Lines starting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3095 made the bridge more promise- aware. A WebAPI with a
!js.Promisereturn type that returns an error will not reject the promise.That PR was limited to Crypto. This expands it where possible. Generally speaking, the result is just more idiomatic Zig code. From:
to:
However, because TypeErrors must often reject with a specific message, we use a pseudo-global in Env. So, you'd do:
which return error.TypeError AND stores "invalid algorithm" on the
Env. WhenCallergetserror.TypeErrorit checks the Env for a message. Who says Zig errors can't carry payloads?!;# Please enter the commit message for your changes. Lines starting