Limit exported symbols to lp_* on MacOS - #3108
Merged
Merged
Conversation
This was all Claude. I'm not good enough at builds. But the issue appears to be that the MacOS build exports everything and the only solution is to hide them at compile time. This does not work for v8 (which goes through its own build system), but Claude says it's fine since those are mangled and would only conflict if the user embedded v8 directly also.
arrufat
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was all Claude. I'm not good enough at builds. But the issue appears to be that the MacOS build exports everything and the only solution is to hide them at compile time. This does not work for v8 (which goes through its own build system), but Claude says it's fine since those are mangled and would only conflict if the user embedded v8 directly also.
Depends on lightpanda-io/boringssl-zig#2