Skip to content

Cut 0.1.0-alpha.1#102

Open
tankyleo wants to merge 5 commits into
lightningdevkit:mainfrom
tankyleo:2026-06-v0.1.0-alpha.1
Open

Cut 0.1.0-alpha.1#102
tankyleo wants to merge 5 commits into
lightningdevkit:mainfrom
tankyleo:2026-06-v0.1.0-alpha.1

Conversation

@tankyleo
Copy link
Copy Markdown
Contributor

@tankyleo tankyleo commented Jun 4, 2026

No description provided.

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Jun 4, 2026

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested a review from tnull June 4, 2026 00:46
@tankyleo tankyleo force-pushed the 2026-06-v0.1.0-alpha.1 branch 3 times, most recently from e8fa92e to a064d1d Compare June 4, 2026 01:39
@tankyleo tankyleo force-pushed the 2026-06-v0.1.0-alpha.1 branch from a064d1d to dbb585c Compare June 4, 2026 02:10
Copy link
Copy Markdown
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments on the changelog, and starting with -alpha.1 is a bit uncommon, otherwise looks good.

Comment thread Cargo.toml
default-members = ["server"]

[workspace.package]
version = "0.1.0-alpha.1"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: -alpha.1 is usually the second alpha release, as -alpha or alpha.0 is usually the first.

Comment thread CHANGELOG.md

Initial alpha release of the Versioned Storage Service server.

This release is source-only; no crates.io packages, prebuilt binaries, or Docker images are published.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't belong in a CHANGELOG, especially since package publication would happen after this is merged anyways (and we should publish to crates.io, no?)

Comment thread CHANGELOG.md

## Added

- VSS service implementing VSS protocol version 0.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this more succinct as it's just "what happened so far". For changelog-style entries we'd otherwise want to highling specific features/bugfixes and link to specific PRs for further reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants