Conversation
…e Modelling
The economic_curves library was a mirror of insurance_python by
Open-Source Modelling (formerly Actuarial Algorithms). The upstream
repositories have kept evolving while the mirror in lifelib was left
untouched, so the shipped scripts and rendered notebooks had become stale.
Remove the mirrored contents and link to the upstream repositories instead:
* Delete all scripts, notebooks and data under
lifelib/libraries/economic_curves and leave a README.md explaining that
the library is now only a placeholder and where its contents went.
* Rewrite doc/source/libraries/economic_curves/index.md as an introduction
to Open-Source Modelling, with links to the algorithms in insurance_python,
the notebooks in insurance_jupyter and their other active repositories.
Delete the per-algorithm pages and the nblink files that pointed at the
removed notebooks.
* Drop the economic_curves section from the Notebooks page and its entry
from the front-page Notebooks card. The notebooks_economic_curves label
is kept on the new library page so that the v0.8.0 release notes still
resolve.
* Update the library description in the Libraries index.
* Include .md files in package_data so that the placeholder README ships
with the package and lifelib.create("economic_curves") still works.
Closes #109
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013oCfTyhMEbsdU6HwDAUw4h
Member
Author
|
@open-source-modelling this takes the "just leave a link" option from #109 — your work is no longer mirrored here, and the lifelib page now introduces Open-Source Modelling and links straight to your repositories. A few points where your input would be most useful:
You mentioned a deeper integration as the other option. Nothing here blocks that later; the placeholder page is easy to replace if you would like to revisit it. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #109.
The
economic_curveslibrary was a mirror of insurance_python by Open-Source Modelling (formerly Actuarial Algorithms). The upstream repositories have kept evolving while the mirror in lifelib was left untouched, so the shipped scripts and the rendered notebooks had become stale.This PR removes the mirrored contents and points to the upstream repositories instead.
Changes
lifelib/libraries/economic_curves/— all 27 files (scripts, notebooks, LICENSEs, xlsx) removed, replaced by a singleREADME.mdexplaining that the library is now only a placeholder and where its contents went.doc/source/libraries/economic_curves/index.md— rewritten as an introduction to Open-Source Modelling:insurance_python, each linked, with the upstream source references. This is more than the 9 that were mirrored — Vasicek one/two factor, Hull-White one factor, Dothan one factor and singular spectrum analysis have been added upstream since;Open_Source_Economic_Model,Light_Economic_Generator,Validation_Economic_Stochastic_Generator,EIOPA_all_curves,SFCR_using_Mistral_2025,IMF_GDP_pipeline,EDGAR_pipeline,insurance_matlab).The 14 per-algorithm
.mdpages and.nblinkfiles are deleted — theyincluded READMEs and notebooks that no longer exist, so the build would break otherwise.Reference plumbing — the
economic_curvessection is removed from the Notebooks page and from the front-page Notebooks card, but thenotebooks_economic_curveslabel now lives on the new library page so the v0.8.0 release notes still resolve without rewriting them. The{module} economic_curvesdirective is kept for the same reason (:mod:references inupdates.rstand the release notes).setup.py—mdadded to the packaged extensions, so the placeholder README ships in the wheel andlifelib.create("economic_curves", ...)still works instead of raisingKeyError. This also picks up one pre-existing file,smithwilson/smith-wilson-py/README.md.A note on where the notebooks live
The issue mentions linking the notebooks in
insurance_python, but that repository no longer contains notebooks — they have been split out intoinsurance_jupyter. The notebook links therefore point atinsurance_jupyterrather than at paths that no longer exist.Verification
:ref:notebooks_economic_curvesand `:mod:`~economic_curvesresolve to the new page.lifelib.create("economic_curves", path)produces a folder containing justREADME.md.No release-notes entry or
updates.rstitem was added, since there is no in-progress release file; that seemed like a release-time call.Generated by Claude Code