Make our Threads:: pthreads backend respect grainsize, make grainsize runtime-configurable#4476
Make our Threads:: pthreads backend respect grainsize, make grainsize runtime-configurable#4476roystgnr wants to merge 6 commits into
Conversation
Having the magic number 1000 everywhere was poor form.
I'm probably not going to make this controllable (which would require an additional member variable that I'm only 99% sure would be optimized out) until/unless people start reporting real performance gains from per-loop grain size tweaking.
|
Oh, now I'm starting to understand. The reason MOOSE doesn't speed up is that it's got a hardcoded |
|
Even with the |
I found another MOOSE bug that explains most or all of it, and that suggests other downstream issues which could explain the rest. The changes here should be good, though I'll want to wait to re-run CI on a post- idaholab/moose#33049 MOOSE before we merge. |
|
Job Test MOOSE ARM mac on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE modules debug on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE GCC min on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE clang on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE conda on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE modules on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE debug on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE recover and restep on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
|
Job Test MOOSE LibTorch on 4beb677 : invalidated by @loganharbour re-run after idaholab/moose#33049 |
2 participants
This doesn't yet fix the MOOSE performance issues I was expecting it to, but I think it's either a step towards that or a worthwhile change on its own.