Skip to content

Miscellaneous UI fixes: channel table filter reset, SidePanelModal padding, status button width - #6062

Open
AlexVelezLl wants to merge 3 commits into
learningequality:unstablefrom
AlexVelezLl:fix/channel-table-status-filter-reset
Open

Miscellaneous UI fixes: channel table filter reset, SidePanelModal padding, status button width#6062
AlexVelezLl wants to merge 3 commits into
learningequality:unstablefrom
AlexVelezLl:fix/channel-table-status-filter-reset

Conversation

@AlexVelezLl

@AlexVelezLl AlexVelezLl commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

Found while working on the community library submissions flow for another fix. Three small, unrelated UI/UX bugs surfaced along the way, bundled together here:

  • The admin Channels table reset its status filter (e.g. "Needs review") when navigating back to it, since an unconditional reset watcher fired on every mount instead of only when the status became genuinely invalid for the selected type.
  • Consumers of SidePanelModal lost their internal padding after a prior PR removed it from the shared component.
  • The community library status button had a fixed width that clipped longer labels.

The Side Panel bugs are only reproducible on unstable.

Reviewer guidance

To manually verify the channel table fix: in the admin Channels table, filter by "Community Library" + "Needs review", open a channel, then use the browser Back button — the filters should stay as set instead of resetting.

Before After
image image
image image

AI usage

Used Claude Code throughout: diagnosed the channel-table filter-reset bug via code exploration, implemented and iterated on the fix. I reviewed all diffs, decided the final fix approach for the filter bug, and ran the test suite and pre-commit before this PR.

AlexVelezLl and others added 3 commits July 31, 2026 15:16
…table

Navigating back to the admin Channels table (e.g. after opening a
channel and using the browser back button) reset the status filter
even though it was correctly restored from the URL. An immediate
watcher unconditionally overwrote it to the first available option on
every mount instead of only defaulting when the filter is actually
unset. Since the status filter is derived from the current channel
type's options, a status no longer valid for a new type already reads
back as unset, so a single "is it set" check covers both the
type-change reset and back-navigation preservation.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
SidePanelModal no longer applies internal padding to its content, so
consumers that relied on it lost their spacing. Add the padding
directly in ReviewSubmissionSidePanel and CommunityLibraryFilters.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The fixed width clipped longer status labels. Let it size to content.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@AlexVelezLl
AlexVelezLl marked this pull request as ready for review July 31, 2026 20:36
@AlexVelezLl
AlexVelezLl requested a review from marcellamaki July 31, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant