Skip to content

fix(verification): regenerate stale planted-bug patches; check they apply in CI - #279

Draft
unbalancedparentheses wants to merge 23 commits into
mainfrom
fix/planted-patches
Draft

unbalancedparentheses wants to merge 23 commits into
mainfrom
fix/planted-patches

Conversation

@unbalancedparentheses

@unbalancedparentheses unbalancedparentheses commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Eleven planted-bug patches (04, 10–17, 19, 20) no longer applied after the 0.8 lifecycle rewrite and the file splits. Each is regenerated to plant the same fault where that code now lives:

# Fault Now in
04 Transient restarts on Shutdown supervision.rs (RestartMode::restarts)
10 Normal link notice kills a non-trapping peer link.rs (apply_signal, link origin only)
11 one-sided unlink: the peer's death still signals the caller link/table.rs (remove_pair)
12 link to a dead peer delivers Normal instead of NoProc link.rs
13 actor killed through a link exits Normal link.rs (apply_signal)
14 administrative Shutdown stop commits Normal child_handle.rs (stop_with_reason; shutdown() is gone)
15 Down delivered after demonitor monitor/fence.rs (both modes)
16 monitoring a dead actor gives no Down monitor/fence.rs
17 exiting observer keeps its monitor waiters monitor.rs
19 run loop handles messages received after stop tasks/actor/lifecycle.rs
20 send enqueues from a spawned task tasks/actor/actor_ref.rs

Three are adapted to the 0.8 design, as explained in TESTING.md: 11, 12 and 14.

Checked locally. All 24 patches pass git apply --check, and all 11 regenerated ones compile (lib and tests). With each patch applied, I ran only the targeted tests, and they caught 04, 10, 11, 12, 13, 15, 16 and 19. For 15, which missed in every layer of the old matrix, the catching tests are demonitor_before_target_dies_suppresses_down and demonitor_releases_waiter, both modes.

CI. A new step in the required model-sync job runs git apply --check on every patch, so they can't rot silently again.

TESTING.md and INDEX.tsv are updated, with a note to rerun the matrix before citing the affected rows.

Model: no change because only verification patches, docs and a CI step change; no modelled code changes.

…-large-files

# Conflicts:
#	benchmarks/experiments/backend-experiments.patch
…-large-files

# Conflicts:
#	benchmarks/experiments/backend-experiments.patch
…-large-files

# Conflicts:
#	benchmarks/experiments/backend-experiments.patch
…marks; map the ReadyGate Loom harness to benchmarks/experiments
…files

# Conflicts:
#	benchmarks/experiments/backend-experiments.patch
#	concurrency/src/tasks/actor.rs

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant