Repository navigation
fix(verification): regenerate stale planted-bug patches; check they apply in CI - #279
Draft
unbalancedparentheses wants to merge 23 commits into
Draft
unbalancedparentheses wants to merge 23 commits into
unbalancedparentheses wants to merge 23 commits into
Conversation
…tor_ref, lifecycle and test submodules
…licy_tests submodules
…andler and sim_test modules
…ches, update docs
…-large-files # Conflicts: # benchmarks/experiments/backend-experiments.patch
…-large-files # Conflicts: # benchmarks/experiments/backend-experiments.patch
…longer_enables_feature)
…-large-files # Conflicts: # benchmarks/experiments/backend-experiments.patch
…marks; map the ReadyGate Loom harness to benchmarks/experiments
…y apply in model-sync
…files # Conflicts: # benchmarks/experiments/backend-experiments.patch # concurrency/src/tasks/actor.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eleven planted-bug patches (04, 10–17, 19, 20) no longer applied after the 0.8 lifecycle rewrite and the file splits. Each is regenerated to plant the same fault where that code now lives:
Shutdownsupervision.rs(RestartMode::restarts)Normallink notice kills a non-trapping peerlink.rs(apply_signal, link origin only)unlink: the peer's death still signals the callerlink/table.rs(remove_pair)Normalinstead ofNoProclink.rsNormallink.rs(apply_signal)Shutdownstop commitsNormalchild_handle.rs(stop_with_reason;shutdown()is gone)Downdelivered afterdemonitormonitor/fence.rs(both modes)Downmonitor/fence.rsmonitor.rstasks/actor/lifecycle.rssendenqueues from a spawned tasktasks/actor/actor_ref.rsThree are adapted to the 0.8 design, as explained in TESTING.md: 11, 12 and 14.
Checked locally. All 24 patches pass
git apply --check, and all 11 regenerated ones compile (lib and tests). With each patch applied, I ran only the targeted tests, and they caught 04, 10, 11, 12, 13, 15, 16 and 19. For 15, which missed in every layer of the old matrix, the catching tests aredemonitor_before_target_dies_suppresses_downanddemonitor_releases_waiter, both modes.CI. A new step in the required
model-syncjob runsgit apply --checkon every patch, so they can't rot silently again.TESTING.md and INDEX.tsv are updated, with a note to rerun the matrix before citing the affected rows.
Model: no change because only verification patches, docs and a CI step change; no modelled code changes.