Skip to content

fix: resetting bg color now also resets foreground/accent color#501

Open
lacymorrow wants to merge 1 commit into
mainfrom
fix/reset-bg-also-resets-highlight-color
Open

fix: resetting bg color now also resets foreground/accent color#501
lacymorrow wants to merge 1 commit into
mainfrom
fix/reset-bg-also-resets-highlight-color

Conversation

@lacymorrow
Copy link
Copy Markdown
Owner

Summary

  • When a user resets the app background color (appBgColor) to its default/unset state, the foreground/accent color (appHighlightColor) was left intact — causing buttons to become invisible against the default background
  • Fix ties the highlight color to the bg color: clearing bg also clears highlight in syncSettings
  • Standalone highlight-color (without a custom bg) is no longer a supported state since the two are visually coupled

Root cause

In syncSettings (src/main/crossover.js), appHighlightColor was applied independently of appBgColor. If bg was reset but highlight was still set to e.g. white, the buttons rendered as white-on-white against the system default background.

Test plan

  • Set a custom App Background Color and App Icon Color in Settings → System Settings
  • Click the color reset/clear button on App Background Color
  • Confirm: App Icon Color is also cleared and buttons are visible
  • Confirm: Setting both colors together still works correctly
  • Confirm: Theme changes (light/dark/system) still reset both colors as before

Closes #3

When appBgColor is cleared/reset, the appHighlightColor was left set,
making buttons invisible against the default background. Now the highlight
color is tied to the bg color — clearing bg also clears highlight.

Closes #3

Co-Authored-By: Paperclip <noreply@paperclip.ing>
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@lacymorrow
Copy link
Copy Markdown
Owner Author

Closing: the bg/highlight color fix was already incorporated into main via #503 (docs: use real app screenshots) which squashed in this fix. No action needed.

@lacymorrow lacymorrow closed this May 18, 2026
@lacymorrow lacymorrow reopened this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant