feat: support changeQuoteRequestState on quote requests - #409
Merged
Conversation
The quote-request update handler implemented setCustomField, setCustomType and transitionState, but not changeQuoteRequestState, so cancelling a quote request could not be exercised against the mock. transitionState is not a substitute: it moves a quote request through a custom State machine, while changeQuoteRequestState sets the built-in quoteRequestState enum.
🦋 Changeset detectedLatest commit: 54a4d8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quote-request update handler implements
setCustomField,setCustomTypeandtransitionState, but notchangeQuoteRequestState— so cancelling a quote request, which maps to that action, cannot be exercised against the mock.transitionStateis not a substitute for it. It moves a quote request through a customStatemachine;changeQuoteRequestStatesets the built-inquoteRequestStateenum. The SDK declares them as two distinct actions.Changes
changeQuoteRequestStateonQuoteRequestUpdateHandler, following the same shape aschangeOrderStateon the order handler — a plain assignment, no transition validation, consistent with how the otherchange*Stateactions behave here.MyQuoteRequestRepository extends QuoteRequestRepository, so the/mepath picks this up unchanged.Verification
pnpm tsc,pnpm biome checkandpnpm test(790 tests) all pass.