fix: include product-level references and meta fields on projections - #404
Merged
Conversation
Transforming a product into a ProductProjection dropped taxCategory,
state, priceMode, metaTitle, metaKeywords and searchKeywords, even though
the product resource already stored all of them -- ProductRepository
resolves taxCategory and state on create, and ProductData carries the meta
fields. Only the transform was leaving them out.
Fixed in both places that build a projection, so the product projection
and product search endpoints do not drift.
This makes expand=taxCategory resolve, so code that reads a projection's
tax category -- to compute net and gross prices at index time, say -- can
be tested against the mock rather than only against the real API.
searchKeywords is non-optional on ProductProjection, so the mock was
emitting a value that did not satisfy its own type. It now always carries
it, defaulting to {}. Tests asserting a whole projection with toEqual need
it added to their expected object; the fixture in this file is updated
accordingly.
🦋 Changeset detectedLatest commit: 7a39a61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Full node/storage-engine coverage stays on ubuntu (now including node 26); Windows and macOS only run node 26 with the in-memory engine.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transforming a product into a ProductProjection dropped taxCategory,
state, priceMode, metaTitle, metaKeywords and searchKeywords, even though
the product resource already stored all of them -- ProductRepository
resolves taxCategory and state on create, and ProductData carries the meta
fields. Only the transform was leaving them out.
Fixed in both places that build a projection, so the product projection
and product search endpoints do not drift.
This makes expand=taxCategory resolve, so code that reads a projection's
tax category -- to compute net and gross prices at index time, say -- can
be tested against the mock rather than only against the real API.
searchKeywords is non-optional on ProductProjection, so the mock was
emitting a value that did not satisfy its own type. It now always carries
it, defaulting to {}. Tests asserting a whole projection with toEqual need
it added to their expected object; the fixture in this file is updated
accordingly.