fix: strip leading whitespace before encoding detection (fixes #508)#570
Open
gaoflow wants to merge 1 commit into
Open
fix: strip leading whitespace before encoding detection (fixes #508)#570gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
…kee#508) When an XML feed starts with a newline before the XML declaration, the encoding detection in convert_to_utf8() fails to find the <?xml encoding attribute, causing it to prepend a second XML declaration which triggers SAX "XML or text declaration not at start of entity" errors. Strip leading ASCII whitespace from the data after BOM detection but before encoding sniffing, so that XML declarations preceded by newlines are correctly detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an XML feed starts with a newline before the XML declaration
(e.g.
\n<?xml version="1.0"...), the encoding detection inconvert_to_utf8()fails to find the<?xmlencoding attributebecause it's not at byte offset 0. This causes a second XML
declaration to be prepended, which trips the SAX parser with
"XML or text declaration not at start of entity".
Fix: strip leading ASCII whitespace from the data after BOM
detection and before encoding sniffing, so that XML declarations
preceded by whitespace are correctly detected.