fix: recognize a trailing [key=slug] token in status-line decisions - #2302
Open
RArgu wants to merge 4 commits into
Open
fix: recognize a trailing [key=slug] token in status-line decisions#2302RArgu wants to merge 4 commits into
RArgu wants to merge 4 commits into
Conversation
A crewmate wrote needs-decision: <summary> [key=x] with the tag at the line's end instead of the documented before-colon position, so fm-send --resolve-key could not close the decision by key. Teach _fm_decision_key and status_line_note to accept a complete [key=slug] token anchored at the line's own end, for opening verbs and resolved lines alike, while a mid-line mention still stays plain prose and the documented before-colon position still wins on disagreement. Add a matching one-line example to the brief scaffold's escalation rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/fm-classify-lib.sh's keyed-decision parser to also accept a trailing[key=slug]token at the end of a status line (forneeds-decision,blocked,paused, andresolvedlines), matching whichever position a worker actually used, while the canonical between-verb-and-colon position remains canonical and wins on disagreement.[key=, so prose glued directly to a bracket group (e.g.cfg[key=env]) is never misread as a stated key.bin/fm-brief.sh's generated status-protocol rules showing the canonical token position unambiguously.Test plan
bash tests/fm-classify-decision-key.test.sh— full suite passes, including new cases for canonical vs. trailing position, mixed open/close positions, mid-line mentions, and boundary rejection.