Skip to content

Unhide --as and --as-group flags for kpt live commands - #4680

Merged
aravindtga merged 1 commit into
kptdev:mainfrom
Nordix:unhide-impersonation-flags
Aug 5, 2026
Merged

Unhide --as and --as-group flags for kpt live commands#4680
aravindtga merged 1 commit into
kptdev:mainfrom
Nordix:unhide-impersonation-flags

Conversation

@aravindtga

Copy link
Copy Markdown
Contributor

Description

  • What changed: Removed "as" and "as-group" from the hidden flags list in run/run.go
  • Why it's needed: Users cannot discover impersonation support via --help, despite the flags being functional. Additionally, --as-uid and --as-user-extra are visible while --as and --as-group are hidden, creating an inconsistency.
  • How it works: hideFlags() in run/run.go:246 marks certain flags as hidden on all commands. Removing "as" and "as-group" from that list makes them visible in kpt live --help and all kpt live subcommands.

Related Issue(s)

Type of Change

  • Bug fix
  • New feature
  • Enhancement
  • Refactor
  • Documentation
  • Tests
  • Other: ________

Checklist

  • Code follows project style guidelines
  • Self-reviewed changes
  • Tests added/updated
  • Documentation added/updated
  • All tests and gating checks pass

AI Disclosure

  • I have used AI in the creation of this PR.

If so, please describe how:
- Kiro (Claude) to investigate the issue, trace the flag registration and hiding logic in the codebase, verify the fix, and draft the PR description.

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 6b72aea
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a71faeaa9b3c200081ce754
😎 Deploy Preview https://deploy-preview-4680--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

sonarqubecloud Bot commented Aug 4, 2026

Copy link
Copy Markdown

@aravindtga
aravindtga marked this pull request as ready for review August 4, 2026 14:54
@aravindtga
aravindtga requested review from a team August 4, 2026 14:54
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/live bug Something isn't working labels Aug 4, 2026
@aravindtga aravindtga self-assigned this Aug 4, 2026
@dosubot dosubot Bot added the lgtm label Aug 5, 2026
@aravindtga
aravindtga merged commit a63be0f into kptdev:main Aug 5, 2026
26 checks passed
@aravindtga
aravindtga deleted the unhide-impersonation-flags branch August 5, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/live bug Something isn't working lgtm size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support impersonation --as option for kpt live

3 participants