Improve fuzz coverage: realloc with --no-default-features#5
Merged
Conversation
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
xermicus
changed the title
--no-default-features
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two smallies regarding the fuzz harness:
New Realloc op in allocator_buffer. The harness already exercises alloc, free, shrink_inplace, and grow_inplace but doesn't touch
Allocator::realloc. This adds aRealloc { index, size }variant that calls realloc with the new size, then mirrors the existing data-integrity bookkeeping:: asserts the surviving prefix(min(old, new) bytes)matches the previously written data, refills the tail on grow with a deterministic pattern so subsequent ops still pass their checks, and updates alive_addresses if the pointer changed.Run
allocator_bufferwithrealloc_inplaceoff too. The fuzz crate's picoalloc dep is restructured to forward the realloc_inplace feature, andci/jobs/fuzz.shinvokes the target twice — once with default features and once with--no-default-features. This way both the in-place and the alloc-copy-free paths inside realloc get fuzzed.With #4 this PR should be green too.