ci: re-enable Windows (DX12/WARP) - #117
Merged
Merged
Conversation
Restore Windows in clippy, test, and MSRV matrices. Windows cargo test uses goldy-dx12-only, serialized binaries (-j 1), and a longer timeout. Add EKRANO_CI_SKIP_SNAPSHOTS for CI-only snapshot skips after WARP diffs. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
Reuse one GoldyRenderer across pipelined_memory trials so DX12 WARP does not TDR on renderer drop. Skip known WARP-vs-reference snapshot names on Windows CI only via EKRANO_CI_SKIP_SNAPSHOTS. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
koubaa
marked this pull request as ready for review
September 4, 2026 04:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enables
windows-latestin clippy, cargo test, and MSRV jobs.Windows test path
--no-default-features -F goldy-dx12-only), NuGet WARP, DXC on PATH,GOLDY_DX12_FORCE_WARPcargo test -j 1so WARP is not shared across processesFixes from the first Windows run
pipelined_memory: creating/dropping a
GoldyRendererper trial TDRs DX12 WARP (GPU device removed, thenFailed to create per-context DX12 fence). Trials now share one process-lifetime renderer.Snapshots (CI-only skip): DX12 WARP vs lavapipe/Metal references. Local runs still compare. Skipped names:
glyphs_decoration_offset_values,glyphs_decoration_size_values,glyphs_decoration_no_descenders(small FLIP overshoot / hinting)scaled_hintedtwo_emoji(COLR/bitmap on WARP)splash,fill_typesluminance_mask(shape luminance mask;image_luminance_maskstill runs)EKRANO_CI_SKIP_SNAPSHOTSis set only on the Windows cargo test step.