ci: stop full apt upgrade and drop unused X11 -dev deps - #108
Merged
Conversation
`apt-get upgrade mesa-vulkan-drivers …` was upgrading the entire ubuntu-24.04 runner (~295 MB: Chrome, PHP, Firefox snap, …), which dominated Linux Vulkan CI setup time. Install only lavapipe + loader + vulkan-tools, and remove libxcb-xfixes0-dev which CI never needed for headless rendering. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
First lavapipe vulkaninfo takes minutes of LLVM init; CI already has a dedicated Verify lavapipe step, so don't pay that cost twice in setup. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
Scanning all of /usr is unnecessary when Ubuntu ships the ICD under /usr/share/vulkan/icd.d/. Check those paths first and add progress echoes so setup timing is visible in CI logs. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
koubaa
marked this pull request as ready for review
July 25, 2026 12:34
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linux Vulkan CI was spending most of its setup time downloading unrelated packages. From a recent
cargo test (ubuntu-24.04)run before this change:apt-get upgrade -y mesa-vulkan-drivers libgl1-mesa-driperformed a full system upgrade (~295 MB): Chrome, PowerShell, PHP, Firefox snap, kubectl, snapd, etc. Intent was only Mesa 25+ for lavapipe Vulkan 1.4.libxcb-xfixes0-devis unused for headless CI. Ekrano/Goldy load Vulkan viaash::Entry::load()and render offscreen; nothing links XCB. That package pulled the XCB/X11-devstack (libxcb1-dev,x11proto-dev, …).vulkaninfobefore CI’s Verify step, and usedfind /usrto locate the ICD.Fix
ci/setup-ubuntu.shnow installs only:mesa-vulkan-drivers(lavapipe ICD)libvulkan1(runtime loader for ash)vulkan-tools(vulkaninfofor the verify step)with
--no-install-recommends. Under GitHub Actions it skips the in-scriptvulkaninfosmoke test (kept for Docker/local), and prefers the known ICD path under/usr/share/vulkan/icd.d/.Measured on this PR
-devRuntime X11/Wayland libs that Mesa itself depends on (
libxcb-*,libwayland-client0) may still appear as transitive deps ofmesa-vulkan-drivers; those are small and usually already on the runner.Test plan
mesa-vulkan-drivers+vulkan-tools(17.8 MB)-devpackages in the install step