fix curve dashes - #106
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Paid org GPU runners are unavailable after the move to koubaa; use free ubuntu-24.04 with the existing lavapipe setup script. Co-authored-by: Cursor <cursoragent@cursor.com>
Early `return` before GroupMemoryBarrierWithGroupSync in backdrop_dyn (and sibling shaders) prevented the hillis-steele backdrop prefix scan from completing on lavapipe, leaving interior tiles with backdrop=0 so coarse skipped solid fills. Gate work on failed==0 and only return after barrier-heavy sections (or when the exit is workgroup-uniform). Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
5 tasks
Hardware SampleLevel bilinear differs by ±1–2 between Metal and lavapipe; luminance-mask scenes amplify that past the 0.0095 FLIP budget. Snapshots still reflect Vello's explicit 4-tap path — restore that for image atlas reads (atlas remains CPU-premultiplied). Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
…e flags - Re-enabled Windows testing in the CI workflow, adding specific test commands for Windows with DX12 support. - Updated Cargo.toml files across multiple projects to include new feature flags for goldy backends, allowing for more granular control over dependencies. - Set default features to false for dependencies to ensure compatibility and reduce unnecessary bloat during builds. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
- Added comments indicating the need to re-enable Windows testing when the CI is stable. - Removed Windows-specific test commands from the CI matrix for now. - Marked steps for Windows testing as ready for re-integration once conditions are met. Co-authored-by: Mohamed Koubaa <koubaa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as was done in linebender/vello#303