Improve Performance of Parsing - #798
Open
aannleax wants to merge 7 commits into
Open
Conversation
Member
|
Can we please wait with this until the N3 parsing has landed? This will produce tons of merge conflicts. |
Member
Author
|
Sure this can wait. I haven't checked, but it would surprise me if the changes here conflict much; unless you rewrote error handling or changed how existing structures are parsed |
Member
There are quite a few refactors to existing structures in there, because N3 needs subtly different versions and I didn't want to duplicate everything. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of the parser. This is accomplished by
Changes in 1 also slightly improve the parser error messages.