Skip to content

Stop logging environment in e2e sendEvent - #608

Merged
knative-prow[bot] merged 1 commit into
mainfrom
fix/ics-send-env-log
Nov 1, 2026
Merged

knative-prow[bot] merged 1 commit into
mainfrom
fix/ics-send-env-log

Conversation

Copilot AI commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove serialized command logging from sendEvent() so process environment variables are not exposed in logs.

Validation

  • E2E package compiles with the e2e build tag.
  • Running e2e tests requires a Kubernetes kubeconfig.

Remove serialized command logging from the e2e sendEvent helper so process environment variables are not exposed in logs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@knative-prow knative-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2026
@knative-prow
knative-prow Bot requested review from cardil and dsimansk November 1, 2026 14:50
@knative-prow

knative-prow Bot commented Nov 1, 2026

Copy link
Copy Markdown

Hi @Copilot. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2026
@dprotaso

dprotaso commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@knative-prow knative-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 1, 2026
@dprotaso
dprotaso marked this pull request as ready for review November 1, 2026 14:53
@knative-prow knative-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2026
@dprotaso dprotaso linked an issue Nov 1, 2026 that may be closed by this pull request
@dprotaso

dprotaso commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2026
@knative-prow

knative-prow Bot commented Nov 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Copilot, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2026
@dprotaso

dprotaso commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick release-1.24
/cherry-pick release-1.23

@knative-prow-robot

Copy link
Copy Markdown

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.23, release-1.24 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-1.24
/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (4bfa365) to head (be72682).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #608   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files          52       52           
  Lines        1408     1408           
=======================================
  Hits          952      952           
  Misses        386      386           
  Partials       70       70           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow
knative-prow Bot merged commit 9e4a30f into main Nov 1, 2026
29 checks passed
@knative-prow-robot

Copy link
Copy Markdown

@dprotaso: new pull request created: #609

Details

In response to this:

/cherry-pick release-1.24
/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot

Copy link
Copy Markdown

@dprotaso: new pull request created: #610

Details

In response to this:

/cherry-pick release-1.24
/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Critical Security Issue in sendEvent() in ics_send.go

3 participants