Repository navigation
Stop logging environment in e2e sendEvent - #608
Conversation
Remove serialized command logging from the e2e sendEvent helper so process environment variables are not exposed in logs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Hi @Copilot. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Copilot, dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.24 |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 52 52
Lines 1408 1408
=======================================
Hits 952 952
Misses 386 386
Partials 70 70 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@dprotaso: new pull request created: #609 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dprotaso: new pull request created: #610 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
sendEvent()so process environment variables are not exposed in logs.Validation
e2ebuild tag.