Repository navigation
docs(rfc): propose the wait-screen game shown while the dashboard waits for its gateway - #39436
jeeshofone wants to merge 1 commit into
Conversation
…ts for its gateway
Design Review (Opus 5.5, fork) —
|
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
First Principles Review (Opus 5.5, fork) —
|
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
Code change approver recommendation: A person should decideWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D. Docs-only draft RFC that answers the First Principles block on #39420, as CONTRIBUTING.md requires for a changed default (an RFC in its own PR). The front matter matches the other RFCs, and the status stays draft, with the decision explicitly left to a maintainer. Every code reference checked exists on this head: isLoopbackHost, UpdateOverlay and the host-offline cover in App.tsx, UpdateFoundModal.tsx, FOLLOWUP_START_SENDS_KEY, ChatPanel.tsx, MissionControlScene and electron/loading.html. The README row and audit sentence follow the existing conventions. No trust boundary moves and no code changes, so no tests are needed. Nothing blocks. Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
|
This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). Review result: no blocking findings on this head. The diff is documentation only: a draft RFC and its row in the request-for-change index. No code or tests change. The review checked the RFC's code claims against main and against the implementation in #39420, and they match: the 30 second delay constant, the capture-phase Space listener, the loopback-only gate, the 25 catalog keys and the tests the RFC lists. The RFC sets out the one decision as three concrete options with a recommendation. It also treats the "Play while you wait" button fairly as the strongest alternative. Optional notes:
|
Problem / Motivation
Goal: A maintainer can record whether the wait-screen game in #39420 ships on by default, with or without an off switch, or as a button.
#39420 adds a small laundry-folding game below the status text of the host-offline cover, the update overlay's reconnect step and the update dialog's restart, on loopback dashboards only, shown on its own after 30 s or on Space. First Principles blocked it (comment): "product-shape change without accepted RFC".
CONTRIBUTING.mdsends a changed default to an RFC first, as its own pull request.Why it matters
The game changes what every local user sees during an outage or update, and nobody has recorded a decision to ship it. This document gives a maintainer that decision to make, so #39420 can be accepted, changed or dropped on the record.
Not a goal
draftuntil a maintainer records the decision.What changed (motivation → approach → change)
A docs-only RFC,
docs/request-for-change/rfc-wait-screen-game.md, plus its README index row and audit sentence. It asks a maintainer to choose between: on by default with an opt-out setting added to #39420 before it merges (recommended), on by default with no setting, or a "Play while you wait" button with no auto-show. It lists the rejected alternatives with reasons, the non-goals, accessibility, tests and rollback (agit revertof #39420 removes it).Backwards compatibility
Compatible: documentation only.
Tests
Docs only.
scripts/docs-lint.shpasses locally.Manual verification
N/A -- documentation only.
Real-machine verification
N/A -- documentation only; nothing runs.
Screenshots / video
N/A -- no UI change in this PR; #39420 carries the screenshots.
Related Issues
Part of #39419
Answers the First Principles block on #39420.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributed under the project's Apache-2.0 license.