Skip to content

docs(rfc): propose the wait-screen game shown while the dashboard waits for its gateway - #39436

Open
jeeshofone wants to merge 1 commit into
kirodotdev:mainfrom
jeeshofone:rfc/wait-screen-game
Open

jeeshofone wants to merge 1 commit into
kirodotdev:mainfrom
jeeshofone:rfc/wait-screen-game

Conversation

@jeeshofone

@jeeshofone jeeshofone commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A maintainer can record whether the wait-screen game in #39420 ships on by default, with or without an off switch, or as a button.

#39420 adds a small laundry-folding game below the status text of the host-offline cover, the update overlay's reconnect step and the update dialog's restart, on loopback dashboards only, shown on its own after 30 s or on Space. First Principles blocked it (comment): "product-shape change without accepted RFC". CONTRIBUTING.md sends a changed default to an RFC first, as its own pull request.

Why it matters

The game changes what every local user sees during an outage or update, and nobody has recorded a decision to ship it. This document gives a maintainer that decision to make, so #39420 can be accepted, changed or dropped on the record.

Not a goal

What changed (motivation → approach → change)

A docs-only RFC, docs/request-for-change/rfc-wait-screen-game.md, plus its README index row and audit sentence. It asks a maintainer to choose between: on by default with an opt-out setting added to #39420 before it merges (recommended), on by default with no setting, or a "Play while you wait" button with no auto-show. It lists the rejected alternatives with reasons, the non-goals, accessibility, tests and rollback (a git revert of #39420 removes it).

Backwards compatibility

Compatible: documentation only.

Tests

Docs only. scripts/docs-lint.sh passes locally.

Manual verification

N/A -- documentation only.

Real-machine verification

N/A -- documentation only; nothing runs.

Screenshots / video

N/A -- no UI change in this PR; #39420 carries the screenshots.

Related Issues

Part of #39419

Answers the First Principles block on #39420.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@jeeshofone
jeeshofone requested review from a team and KiroCrewCaptain as code owners November 19, 2026 10:20
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Nov 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ⚠️ could not complete

The design review did not produce a verdict for 0f26cb3ac5ace59d185a894508ec8e644049d772 (the review step never ran, because an earlier step in this job failed — no model call was made). See the Fork Design Review job logs. Does not block merge.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed 0f26cb3ac5ace59d185a894508ec8e644049d772 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 0f26cb3

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ⚠️ could not complete

The first-principles review did not produce a verdict for 0f26cb3ac5ace59d185a894508ec8e644049d772 (the review step never ran, because an earlier step in this job failed — no model call was made). See the Fork First Principles Review job logs. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — ⏭️ skipped

Revision 0f26cb3ac5ace59d185a894508ec8e644049d772 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed 0f26cb3ac5ace59d185a894508ec8e644049d772 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 0f26cb3

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 19, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D.

Docs-only draft RFC that answers the First Principles block on #39420, as CONTRIBUTING.md requires for a changed default (an RFC in its own PR). The front matter matches the other RFCs, and the status stays draft, with the decision explicitly left to a maintainer. Every code reference checked exists on this head: isLoopbackHost, UpdateOverlay and the host-offline cover in App.tsx, UpdateFoundModal.tsx, FOLLOWUP_START_SENDS_KEY, ChatPanel.tsx, MissionControlScene and electron/loading.html. The README row and audit sentence follow the existing conventions. No trust boundary moves and no code changes, so no tests are needed. Nothing blocks.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 0f26cb3ac5 · 134 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This changes behaviour users already rely on, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here.

To propose a design, follow the request-for-change process in CONTRIBUTING.md (docs/request-for-change/).

Review result: no blocking findings on this head. The diff is documentation only: a draft RFC and its row in the request-for-change index. No code or tests change. The review checked the RFC's code claims against main and against the implementation in #39420, and they match: the 30 second delay constant, the capture-phase Space listener, the loopback-only gate, the 25 catalog keys and the tests the RFC lists. The RFC sets out the one decision as three concrete options with a recommendation. It also treats the "Play while you wait" button fairly as the strongest alternative.

Optional notes:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor) readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants