Repository navigation
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the change renames the existing row instead of adding a new one, reuses the popup's own blocks, and comes with before/after screenshots for every surface it changes. Notes
[DESIGN-REVIEWED] ab93aaf Description read[DESCRIPTION-READ] 582e3871276b3d8bab3f217ea1f02b177f7bfce5cb6dfd7e99916435f5408e7e That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🔴 BLOCKPremise-level review of First-Principles-Verdict: BLOCK Product-shape change without accepted RFC: the change renames the Settings row for everyone and takes away the phone's Kiro Account entry. No RFC on the base or maintainer override records either decision. Owner approval on #39372 is neither of the two accepted forms. What this change shipsInventory (9 items) — 7 justifiedIntent: give the account a visible home and give the phone a single account entry. This is an ADDITION (plus a relabel and a removal).
Blockersproduct-shape change without accepted RFC: Settings relabel and phone account-entry replacement — product shape [FIRST-PRINCIPLES-REVIEWED] ab93aaf Description read[DESCRIPTION-READ] 079db764b9eb2c3a21b1ebb2899c086ad9fa8048c7fcf8a85f8266057f57c7a7 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review — 🔴 changes requested (blocking)GPT 6.1 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- website/src/pages/developer/KiroCreditsCard.tsx:23 -- Preserve the phone’s subscription-management action
[BLOCK-MERGE] fc6ccda Adjudication (Opus 5.5) — is blocking on each finding proportionate?F1 — MEDIUM: on the phone, the dashboard no longer has any link to manage the account or subscription. Confirmed in code:
The real fix is cheap: move the link into its own exported component and render it in both the modal and the card. That adds no state or coordination, so blocking on it costs one small edit. False positive or not applicable? A repository writer can comment: |
|
Owner decision (Zezhen, product owner): rename the rail's Settings row and page title to Account & Settings with the signed-in account's initials as its icon (an empty person circle when signed out), and remove the phone's separate Kiro Account row, moving its credits into a Credits section on Settings -> Kiro account. The desktop topbar credit popup stays. Decided on real-SPA mocks reviewed in #39372; this PR implements exactly that decision. |
|
AI-review override not recorded: |
UX Review (Opus 5.5) — 🔴 BLOCKUX-level review of UX-Verdict: BLOCK The Kiro account tab now shows "Signed in with IAM Identity Center" and, right below it, an unexplained "Sign in" button. A user can't tell whether they are signed in, and won't press the one button that fixes "Not signed in". BlockersThe new Credits section contradicts the sign-in card below it Notes
[UX-REVIEWED] ab93aaf Description read[DESCRIPTION-READ] 37041cb40dc3e0e17d3770c4c92d5ecbb7805aac6bc48b40c17bb14b93c1bbcd That sha256 names everything this verdict read: the PR description, plus the 21 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
AI-review override not recorded: |
The rail's Settings row becomes Account & Settings and draws the signed-in account's initials (an empty person circle with no reading), so a glance shows where the account lives and which one is signed in. The phone's separate Kiro Account row is gone from both drawers: its balance now shows as a Credits section at the top of Settings -> Kiro account, which also appears on a Kiro harness whose build does not offer the sign-in, so the phone keeps a way to its credits. The desktop keeps the topbar capsule and its popup. Closes #39372
The Credits section on Settings -> Kiro account now carries the popup's Manage account & subscription link, so the phone keeps it after its Kiro Account row left. Balance and credits searches find that tab, and the find_ui and nav-label pins follow the rename. The feature map names the new Credits card and avatar files.
b6317bc to
ab93aaf
Compare
|
AI-review override not recorded: |
|
feels overloaded... maybe separate account and settings? |
Problem / Motivation
Goal: The rail's Settings row becomes Account & Settings with the signed-in account's avatar, and the phone shows its Kiro credits inside Settings -> Kiro account instead of a separate Kiro Account row.
Account things are hard to find. The account lives inside Settings, but the rail row is a plain gear, so nothing says the account is there or which one is signed in. On the phone the nav drawer and the chat drawer's rail carry two rows that both mean "my account": Kiro Account (opens the credit popup) and Settings (which holds the Kiro account tab).
Why it matters
Everyone who checks their credits or switches accounts has to guess between two entries for one thing on the phone, and on every screen there is no glance-level sign of which account is signed in. This was raised and approved by the owner on #39372 from real-SPA mocks.
Not a goal
Settings -> <tab>: tab names are unchanged, so those paths still name real tabs.What changed (motivation → approach → change)
Goal: make the account visible where it lives, and give the phone one account entry. Approach: rename the one row instead of adding a new one, reuse the popup's own identity and usage blocks on the page instead of building a second credit view.
nav.settingsandpages.settingsPage.settingsread Account & Settings in all 12 catalogs plus the pseudolocale. Every UI path built fromnav.settings(follow-up cards, command palette provider, find_ui) follows.components/AccountAvatar.tsxdraws the reading's initials (lib/emailInitials.ts, moved out ofKiroAccountModal.tsxunchanged) or an emptyUserRoundcircle with no reading. It is the row's icon in the desktop rail (26px), the phone nav drawer and the chat drawer's rail (30px). The nav row pins its icon slot to 20px, so the circle is drawn centred on that slot instead of resized by it.shell/nav/navRail.tsxand the tile inApp.tsxare gone, with their find_ui locationshell.kiro-accountand itskiro_account_entrycondition.pages/developer/KiroCreditsCard.tsxrenders the popup'sAccountIdentityandCreditUsage(now exported) as a Credits section above Kiro sign-in, with the popup's Manage account & subscription link (now the sharedManageKiroAccountLink), gated on the samekiroAccountEntrythe phone row used. The tab now shows when the build offers Kiro sign-in or that section has something to show, so a Kiro-harness build without KAS sign-in still gives the phone a way to its credits.useKiroUsageReadoutmoved toshell/topbar/kiroAccountReading.ts(useKiroAccountReading) so the Settings page reads the balance without the popup's open state or the sign-in navigation hook.useKiroUsageReadoutcomposes it and behaves as before.website/docs/narrow-viewport.mddescribes the new phone shape; the feature-request skill and its prompt fallback name the pathAccount & Settings › About › Support › Report a Problem; command-palette keywords for the Kiro account tab gain credits/balance/usage/plan, and find_ui search terms (uiLocations/descriptors.ts) send balance and credits questions to that tab.Backwards compatibility
Compatible: routes, tab keys and config are unchanged;
/settings/kiro-accountdeep links still land, and the desktop popup is untouched.Reader: website/src/uiLocations/areas/shell.ts:shell.kiro-account -- entry: chat (find_ui) -- removed with the row it described;
src/kiro_crew/docs/ui-index.generated.jsonandwebsite/src/uiLocations/guidePlans.gen.tsregenerated bynpm run gen:uiReader: website/src/uiLocations/conditions.ts:kiro_account_entry -- entry: chat (find_ui) -- its only placement was shell.kiro-account; no other location requires it (git grep)
Reader: website/src/uiLocations/shell-notifications.locations.test.ts:shell.kiro-account -- entry: release (CI) -- row removed with the location
Reader: website/src/shell/appShell.tsx:kiroAccountEntry -- entry: crew page -- its two readers (navRail.tsx, App.tsx) were the removed rows; SettingsPage reads it from useKiroAccountReading
Reader: website/src/components/KiroAccountModal.tsx:emailInitials -- entry: crew page -- moved to lib/emailInitials.ts and imported back;
AccountAvatar.test.tsxpins itTests
KiroCreditsCard.test.tsx(new): the Credits section carries the Manage account & subscription link after the usage block.test_find_ui_shell.py: "kiro account balance" and "Kiro 账户" findsettings.tab.kiro-account; the phone-only row test is gone with the row.test_docs_connections_paths.py: the nav label pin reads Account & Settings.AccountAvatar.test.tsx(new): initials rule, and the empty circle fornull,none,failed,signin-required.App.mobileSingleTopbar.test.tsx: the phone tile and nav-drawer row are named Account & Settings, drawZXfor a reading and the empty circle without one, and neither drawer offers a Kiro Account entry.SettingsPage.agentHarnessSignIn.test.tsx: no Kiro account tab on a non-Kiro harness that cannot use the sign-in; the tab stays, with Credits and no sign-in card, on a Kiro harness that cannot.App.test.tsx,navShortcutHint.test.tsx,App.navPendingRoute.test.tsx,test_find_ui.py,test_find_ui_auto.py,featureRequestRouting.test.ts: the row and path label read Account & Settings.Proof: not provable -- frontend test
Manual verification
Both sides run as isolated pods with the
minimalseed and the usage read stubbed to a fake account (zezhen.xu@example.com): before =main75424e9, after = head b6317bc. All shots below are from those two builds.Real-machine verification
Machine: Linux dev desktop (AL2, x86_64), pods via
kirocrew pod up --seed minimalBefore (main 75424e9): gear row labelled Settings; phone drawers show a Kiro Account row; the Kiro account tab has only Kiro sign-in.
After (head b6317bc): ZX / empty-person row labelled Account & Settings; no Kiro Account row; the tab shows Credits above Kiro sign-in; the desktop popup is unchanged.
Cleanup: both pods stopped with
kirocrew pod down, own computerScreenshots / video
#1 Desktop rail, signed in
#6 Phone drawer rail, signed in
#5 Phone, Settings -> Kiro account
All pairs (#2, #3, #4, #7, #8, #9)
#2 Desktop rail, signed out
#3 Settings page title
#4 Desktop, Settings -> Kiro account
#7 Phone nav drawer, signed in
#8 Phone drawer rail, signed out
#9 Desktop credit popup (unchanged)
Related Issues
Closes #39372
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.