Repository navigation
ci: run the python 3.9 client job on ubuntu-24.04 - #39351
Conversation
The kirocrew-client (py3.9) job fails in actions/setup-python: the runner boots ubuntu-26.04, and setup-python has no Python 3.9 build for that image. The package declares requires-python >= 3.9, so the floor job must keep running. The 3.9 matrix entry sets runner: ubuntu-24.04, and runs-on reads matrix.runner before the larger-runner label. The 3.12 entry keeps the label.
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. Pinning the 3.9 floor job to Notes
[DESIGN-REVIEWED] f625050 Description read[DESCRIPTION-READ] e0848c2b38548400f9ca019f7ac0c0338ca23624156e48a3e53d511fde98761f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: this fixes the one matrix entry that fails, and no other workflow pins Python 3.9. Notes
What this change shipsInventory (3 items) — 2 justifiedIntent: get the Python client's 3.9 CI job running again so client PRs and merge groups can land. This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] f625050 Description read[DESCRIPTION-READ] de92026de25b9b3364bec5d3cf48cc2e2fd491c5cbddff6b017b0405add61980 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
Thanks for the fix. The review checked these things on this head:
- The new
includeentry changes only the existing 3.9 matrix leg and adds no third job. The 3.12 leg has nomatrix.runner, so it falls back to the unchanged label expression. - On this head's CI,
kirocrew-client (py3.9)ran onubuntu-24.04and passed.kirocrew-client (py3.12)stayed onkirocrew-linux-4-coreand also passed. On the base, the 3.9 job failed at setup-python. - Job names, triggers, permissions and steps are unchanged. No workflow test pins this
runs-on.
Done well: you override only the one leg that needs it, and the doc paragraph that lists this label site changed in the same commit, so it stays accurate.
Optional:
ubuntu-24.04will be retired some day, so this pin will need another look then.
Problem / Motivation
Goal: The Python client's 3.9 test job runs again, so a client change can pass CI and a merge group.
The
kirocrew-client (py3.9)job fails atactions/setup-pythonwith "The version '3.9' with architecture 'x64' was not found for Ubuntu 26.04." Thekirocrew-linux-4-corelabel boots ubuntu-26.04, and setup-python has no 3.9 build for it. Seen on #39347, run 44437435061.Why it matters
Every PR that touches
packages/kirocrew-client-pygets this red, andmerge-queue-readiness.ymlpollsclient-py.yml, so a merge group with such a change cannot land. The package declares Python 3.9 as its floor, so dropping the job would stop testing a supported version.Not a goal
What changed (motivation → approach → change)
The job fails because the image has no 3.9. The 3.9 matrix entry now sets
runner: ubuntu-24.04, the newest hosted image that setup-python has 3.9 for, andruns-onreadsmatrix.runnerbefore the larger-runner label. The 3.12 entry sets no runner and keeps the label. Theci-and-reviews.mdparagraph about these label sites describes theclient-py.ymlexception.Backwards compatibility
Compatible: the job names, the triggers and the 3.12 job do not change. Only the runner of the 3.9 job changes.
Removes nothing: both matrix entries still run.
Tests
Proof: not provable -- docs or config only
The workflow tests that read
client-py.ymlorci-and-reviews.mdpass, 530 tests, among themtest/test_ci_fleet_routing_expression_parity.pyandtest/test_ci_runner_pool_hygiene.py. CI on this PR runs both matrix entries, and the 3.9 job is the check that this works.Manual verification
N/A -- the change is to a workflow, and this PR's own CI run is the verification.
Real-machine verification
N/A -- the diff changes a CI workflow and a doc, and runs nothing on a machine.
Related Issues
Sibling sweep
Swept: git grep -nE "['"]3.(9|10)['"]" -- .github/workflows
Siblings: none -- the only hits are the client-py.yml matrix lines this PR changes
Pattern harvest
Not generalizable: one matrix entry pins the oldest Python the package supports, and only that entry outlived the runner image's toolcache.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsFixes #39350