Skip to content

docs(rfc): propose an edition extension point on the kiro sign-in card - #33999

Open
RohanK6 wants to merge 1 commit into
mainfrom
crew/conductor/f4-rfc
Open

RohanK6 wants to merge 1 commit into
mainfrom
crew/conductor/f4-rfc

Conversation

@RohanK6

@RohanK6 RohanK6 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Propose one frontend extension point on the first-run Kiro CLI sign-in card, so an edition can offer a sign-in action without the core running the login.

#15346 asks for signing in to Kiro CLI without a terminal. Part of it has shipped since it was filed (sign-out detection, a sign-in error card, the queue hold, copyable sign-in commands). On the desktop build the remaining step is pasting a long login command into a terminal, which is where people who chose the desktop app to avoid a terminal give up. The core deliberately does not run kiro-cli login (cb1a54371).

Why it matters

A first-time desktop user who does not use a terminal cannot finish setup without help, and an edition that could offer a better button has nowhere to put it.

Not a goal

  • Running kiro-cli login from the core, a login route, or reading the credential store (cb1a54371).
  • A standing sign-in status line in the default edition (fix(kiro): probe readiness only at boot and drop sign-in chrome #820).
  • Recovery after a mid-use sign-out on the native Kiro CLI backend (error card link, queue release); recorded as an open question for its own RFC.
  • Any code change: this PR is the document only.

What changed (motivation → approach → change)

Adds docs/request-for-change/rfc-kiro-sign-in-card-extension.md (status draft) and its index row. The RFC opens with what main already does, measured at 9268b103b0 with symbol references, then proposes registerKiroSignInAction: one single-slot frontend seam, shaped like registerOverviewPanel, rendered under SignInCommands on the first-run card. It is handed both sign-in commands the card shows (personal and organisation SSO) and the card own Check again, and nothing else; with nothing registered the card is unchanged. The chat row KiroCliSignInRow, which shows the same SignInCommands after a mid-use sign-out on the native Kiro CLI backend, is left out on purpose and named in open question 1. Running the login from the core and a standing status line are recorded under Alternatives considered, citing cb1a54371 and #820. The shape follows mrbeag 2026-10-22 comment on #15346.

Backwards compatibility

Compatible: documentation only; no code, API or config changes.

Removes nothing: a new document and one new index row.

Tests

N/A — documentation only. scripts/docs-lint.sh passes.

Manual verification

N/A — documentation only; every claim about main was re-read at 9268b103b0.

Real-machine verification

N/A — documentation only; the diff runs nothing.

Related Issues

Related: #15346

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project Apache-2.0 license.

@RohanK6
RohanK6 requested review from a team and KiroCrewCaptain as code owners November 9, 2026 17:12
@RohanK6
RohanK6 requested a review from tim-finnigan November 9, 2026 17:12
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of e361511aa7f7b14907f590b2badc4fdce96fd8d5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e361511

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e361511aa7f7b14907f590b2badc4fdce96fd8d5 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision e361511aa7f7b14907f590b2badc4fdce96fd8d5 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision e361511aa7f7b14907f590b2badc4fdce96fd8d5 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 9, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from 26a1879 to d00c8ad Compare November 9, 2026 19:11
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of e361511aa7f7b14907f590b2badc4fdce96fd8d5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a draft RFC that changes no code, renders nothing, and takes nothing away.

Notes

  • Phase 1 adds a seam that nothing in this repository registers ("No edition registers anything in this repository"). Before acceptance, name the first edition that will use it, so the seam is not left with no caller and no way to check it against real use.

[DESIGN-REVIEWED] e361511

Description read

[DESCRIPTION-READ] 76aee6ff6faa9bd32d90bcce445c48ea9377902cf33514098eaebf7a1953c4b4

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed e361511aa7f7b14907f590b2badc4fdce96fd8d5 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e361511

Verdict parsed from the review's SHA-scoped output markers for commit e361511aa7f7b14907f590b2badc4fdce96fd8d5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e361511aa7f7b14907f590b2badc4fdce96fd8d5 false-positive: <reason, 20 to 500 characters>

@Zedmor

Zedmor commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

PR approver recommendation: Approve

Automated, not a person, and not a review: a maintainer still decides. Posted in comment mode, a trial before the approver is allowed to approve PRs itself.

decider-v3c@217fe607 · p_defect 0.06 · router R0 (approves only when p_defect <= 0.10, on PRs of at most 400 changed lines) · head d00c8adf96 · 258 changed lines

Why: the decider approves with p_defect 0.06 <= 0.10 and every rail passes.

Docs-only PR adding a draft RFC for a frontend-only, single-slot registerKiroSignInAction seam on the first-run Kiro CLI sign-in card, plus its index row. Its claims about main check out against the repo: the render site at KiroPrerequisiteGate.tsx:1923, the non-owner screen at line 73, the SignInCommands component, the sign-out-signal comment and the reportSeamCollision / registerOverviewPanel pattern. The design keeps the cb1a54371 decision that the core never runs a login and gives editions nothing the owner can't already see on the card, so no trust boundary moves. The two failing CI checks (one Python backend test shard and the coverage gate) can't be caused by a docs-only diff, and the two AI review lanes that failed did so on GitHub API rate limits without a verdict.

If this recommendation is wrong, reply here; the replies are how the approver is evaluated.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 9, 2026
@bolichen97

Copy link
Copy Markdown
Contributor

Design brief, maintainer read on d00c8ad. This is a draft RFC, and #15346 is T3, so this is a brief only, with no approval.

What it proposes
registerKiroSignInAction: one frontend extension point, with one slot, on the first-run Kiro CLI sign-in card. It is shaped like registerOverviewPanel and collisions go through reportSeamCollision. It renders under SignInCommands in the owner-only installed && !authenticated branch. It is handed only the two command strings the card already shows and the card's own recheck. With nothing registered, the card is unchanged. No edition registers anything in this repo.

Pros

  • It keeps the cb1a54371 decision. The core still spawns only the two read-only probes, with no login route, no URL scraping and no credential-store access.
  • It is small and has no effect by default: one module, one render site and a seam catalogue entry, all frontend.
  • It hands over nothing new. The commands and Check again are already on the owner's screen. The seam is not exported to the app SDK, so App Store apps can't register an action.
  • An error boundary keeps the commands usable if an action throws.

Cons and risks

  • The stock product gains nothing. It only helps an edition that ships its own helper, so the value depends on such an edition existing.
  • An action that offers only one button (personal or SSO) breaks the tier choice the card exists for. The RFC puts this "in the contract" only by doc comment, and nothing enforces it.
  • The real user gap for most installs (mid-use sign-out on native Kiro CLI: no link to a sign-in card, and the queue held until the next send) is left to a future RFC (open question 1).

Tech debt

  • One more single-slot seam to keep stable for editions. That's low, and it matches existing seams. Moving later from one slot to a list (open question 3) would not break it.

Needs a decision on: whether the team wants an edition-only seam here at all, plus open questions 2 (LTS screen: the RFC says no) and 3 (one slot or a list).

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Thanks for the RFC. This is a design proposal, so a maintainer needs to agree to the design before it can merge. A maintainer will post the decision here. This PR already follows the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). The issue it designs for, #15346, is parked and waits on a maintainer decision, so that decision should be made there too.

What the review checked on this head:

  • The diff changes only two docs: the new draft RFC and one index row in the request-for-change README. No code, tests or config change.
  • The audit base d0e911b is an ancestor of main. The commits it cites (cb1a543 and fix(kiro): probe readiness only at boot and drop sign-in chrome #820) say what the RFC says they do.
  • The symbols the RFC names exist on main as described. These include registerOverviewPanel with reportSeamCollision, which throws in dev and warns in production, and SignInCommands inside status.installed && !status.authenticated. The viewer path returns OwnerSetupRequired before the card renders, and ACP_BACKENDS_HOST_AUTH_CALLBACK holds only KAS.
  • The app SDK does not expose seam registrars, so App Store code could not register the action.
  • The quote credited to the In-app Kiro CLI re-authentication (login/logout) from the dashboard #15346 comment is accurate.

No blocking findings. The RFC ties every claim about main to a real file and symbol. It also reuses the existing single-slot seam pattern instead of adding a new mechanism.

Optional:

  • LTS fallthrough: a closed LTS gate that has no lts_sign_in_command falls through to the same first-run card. Phase 1 could add an exit criterion that the action does not render when the LTS gate is closed. That would pin the "LTS: no" answer to open question 2 with a test.
  • The rule that an action with a single button is "out of contract" goes further than Goal 3 ("can keep" the choice), and nothing in the seam can enforce it. You could keep handing both commands to the action and make the choice a recommendation.
  • No edition is named as the one that will register an action. Naming one, as the Design lane suggested, would show the seam has a real consumer.

@RohanK6
RohanK6 enabled auto-merge (squash) November 9, 2026 23:06
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 10, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from d00c8ad to a8193a1 Compare November 10, 2026 18:04
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 10, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from a8193a1 to a5b2636 Compare November 10, 2026 19:07
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 10, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 12, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from a1e1946 to cbf58d6 Compare November 12, 2026 03:03
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Nov 12, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from cbf58d6 to 8238f25 Compare November 12, 2026 05:17
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from 8238f25 to 2f8abab Compare November 12, 2026 06:17
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Nov 12, 2026
@RohanK6
RohanK6 force-pushed the crew/conductor/f4-rfc branch from 2f8abab to f72d364 Compare November 12, 2026 20:42
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Nov 12, 2026
@RohanK6

RohanK6 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

Hi, this PR is ready for review, and it is docs-only.

It touches one file: docs/request-for-change/rfc-kiro-sign-in-card-extension.md, a new draft RFC. It also adds one row to the RFC index in docs/request-for-change/README.md.

Point by point:

  1. What it proposes: an edition extension point on the Kiro sign-in card, so a downstream edition can add to that card without editing core.
  2. What it changes in code: nothing. Status is draft.
  3. Checks: the docs lint passes, and CI is green apart from PR Readiness, which waits on review.
  4. Decision needed: whether the design direction is acceptable for a draft. Implementation would be a separate PR.

Could a maintainer take a look when they have time? Thank you.

Most of what #15346 asked for has shipped: main detects a signed-out
Kiro CLI, posts a sign-in error card, holds the queue for the
post-login resume and shows copyable sign-in commands. What is left is
the sign-in step itself for people who avoid a terminal, and the core
deliberately does not run kiro-cli login (cb1a543).

Propose one frontend seam on the sign-in card that an edition can
register a sign-in action in. With nothing registered the first-run card is
unchanged. Running the login from the core, and a standing sign-in
banner (#820), are recorded as rejected alternatives.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: action required A blocking check or review needs attention

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants