Repository navigation
Conversation
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
26a1879 to
d00c8ad
Compare
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a draft RFC that changes no code, renders nothing, and takes nothing away. Notes
[DESIGN-REVIEWED] e361511 Description read[DESCRIPTION-READ] 76aee6ff6faa9bd32d90bcce445c48ea9377902cf33514098eaebf7a1953c4b4 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
PR approver recommendation: ApproveAutomated, not a person, and not a review: a maintainer still decides. Posted in comment mode, a trial before the approver is allowed to approve PRs itself.
Why: the decider approves with p_defect 0.06 <= 0.10 and every rail passes. Docs-only PR adding a draft RFC for a frontend-only, single-slot If this recommendation is wrong, reply here; the replies are how the approver is evaluated. |
|
Design brief, maintainer read on What it proposes Pros
Cons and risks
Tech debt
Needs a decision on: whether the team wants an edition-only seam here at all, plus open questions 2 (LTS screen: the RFC says no) and 3 (one slot or a list). |
|
Thanks for the RFC. This is a design proposal, so a maintainer needs to agree to the design before it can merge. A maintainer will post the decision here. This PR already follows the request-for-change process in CONTRIBUTING.md (docs/request-for-change/). The issue it designs for, #15346, is parked and waits on a maintainer decision, so that decision should be made there too. What the review checked on this head:
No blocking findings. The RFC ties every claim about main to a real file and symbol. It also reuses the existing single-slot seam pattern instead of adding a new mechanism. Optional:
|
d00c8ad to
a8193a1
Compare
a8193a1 to
a5b2636
Compare
a1e1946 to
cbf58d6
Compare
cbf58d6 to
8238f25
Compare
8238f25 to
2f8abab
Compare
2f8abab to
f72d364
Compare
|
Hi, this PR is ready for review, and it is docs-only. It touches one file: Point by point:
Could a maintainer take a look when they have time? Thank you. |
Most of what #15346 asked for has shipped: main detects a signed-out Kiro CLI, posts a sign-in error card, holds the queue for the post-login resume and shows copyable sign-in commands. What is left is the sign-in step itself for people who avoid a terminal, and the core deliberately does not run kiro-cli login (cb1a543). Propose one frontend seam on the sign-in card that an edition can register a sign-in action in. With nothing registered the first-run card is unchanged. Running the login from the core, and a standing sign-in banner (#820), are recorded as rejected alternatives.
Problem / Motivation
Goal: Propose one frontend extension point on the first-run Kiro CLI sign-in card, so an edition can offer a sign-in action without the core running the login.
#15346 asks for signing in to Kiro CLI without a terminal. Part of it has shipped since it was filed (sign-out detection, a sign-in error card, the queue hold, copyable sign-in commands). On the desktop build the remaining step is pasting a long login command into a terminal, which is where people who chose the desktop app to avoid a terminal give up. The core deliberately does not run
kiro-cli login(cb1a54371).Why it matters
A first-time desktop user who does not use a terminal cannot finish setup without help, and an edition that could offer a better button has nowhere to put it.
Not a goal
kiro-cli loginfrom the core, a login route, or reading the credential store (cb1a54371).What changed (motivation → approach → change)
Adds
docs/request-for-change/rfc-kiro-sign-in-card-extension.md(statusdraft) and its index row. The RFC opens with what main already does, measured at9268b103b0with symbol references, then proposesregisterKiroSignInAction: one single-slot frontend seam, shaped likeregisterOverviewPanel, rendered underSignInCommandson the first-run card. It is handed both sign-in commands the card shows (personal and organisation SSO) and the card own Check again, and nothing else; with nothing registered the card is unchanged. The chat rowKiroCliSignInRow, which shows the sameSignInCommandsafter a mid-use sign-out on the native Kiro CLI backend, is left out on purpose and named in open question 1. Running the login from the core and a standing status line are recorded under Alternatives considered, citingcb1a54371and #820. The shape follows mrbeag 2026-10-22 comment on #15346.Backwards compatibility
Compatible: documentation only; no code, API or config changes.
Removes nothing: a new document and one new index row.
Tests
N/A — documentation only.
scripts/docs-lint.shpasses.Manual verification
N/A — documentation only; every claim about main was re-read at
9268b103b0.Real-machine verification
N/A — documentation only; the diff runs nothing.
Related Issues
Related: #15346
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project Apache-2.0 license.