Repository navigation
Conversation
|
Thanks for this. I checked it against current
What the test reports on the merge: Could you rebase onto |
54e6da4 to
1171f28
Compare
|
Thanks, rebased onto
On this head: |
|
Thanks for the rebase and the extra rows. I re-checked head 1171f28 against current
Keeping the extra rows in this PR is fine. I'm approving the pending CI runs on this head now so the checks can run. |
UX Review (Opus 5.5, fork) — ⏭️ skippedRevision |
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this adds documentation rows plus a parser-driven test that stops the skill drifting from the CLI again, and it takes nothing away. Notes
[DESIGN-REVIEWED] 1171f28 Description read[DESCRIPTION-READ] 1ba033659072cdbed7f8ddd9c87ec3bd5039707febb97bb6855466f847449fc5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. Every added row names a command the base parser registers, and the new test is the only thing linking the parser to the skill (no existing test in Notes
What this change shipsInventory (4 items) — 3 justifiedIntent: let the agent answer questions about every user-facing
[FIRST-PRINCIPLES-REVIEWED] 1171f28 Description read[DESCRIPTION-READ] 0682613e5b62df3d02404618dbb769a7c3bf0a2b41e63efc2307cdcfc904503b That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
…ft out The kirocrew-commands skill is the agent's CLI reference: it loads on help, setup and "what can you do", and the agent answers from its tables. Seventeen user-facing commands had no row in it, so an agent asked how to sign in without kiro-cli, restart a pod, or forget a memory key had nothing to answer from. Adds one row per command, worded from its argparse help: the kas family (with a short section of its own), gateway-pid, open, desktop tunnel, pod restart, memory forget, knowledge stats, app import, secrets authorize and agent pin. A new test captures the parser main() builds and fails on any top-level command in cli_help.COMMAND_GROUPS, or any sub-command registered with a help text, that the skill does not name. It also checks the walk and the matcher cannot pass vacuously. Closes kirodotdev#29816
…was cut The coverage test fails on a merge with main because commands added after this branch was cut have no row in the kirocrew-commands skill. Adds one row per command, worded from its argparse help: acceptance-check, remote-control (status, on, off), models, tmp, agent validate, config pending (list, apply, discard), memory dream (list, run) and memory shadow report.
1171f28 to
34d00e6
Compare
Problem / Motivation
Goal: The
kirocrew-commandsskill names every user-facing CLI command, and a test keeps it that way.The skill is the agent's CLI reference; it loads on help, setup and "what can you do", and the agent answers from its tables. Seventeen user-facing commands had no row: the
kasfamily,gateway-pid,open,desktop tunnel,pod restart,memory forget,knowledge stats,app import,secrets authorizeandagent pin. An agent asked how to sign in without kiro-cli, or how to restart a pod, had nothing to answer from.Why it matters
The agent either says the command does not exist or guesses its flags.
Not a goal
What changed (motivation → approach → change)
The gap was found by walking the parser
main()builds and grepping the skill for each command. The fix adds one row per command, worded from its argparse help, and a short "Kiro Crew's Own Engine (KAS)" section for thekasfamily. A new test captures the same parser and fails on any top-level command incli_help.COMMAND_GROUPS, or any sub-command registered with a help text, that the skill does not name.Backwards compatibility
Compatible: documentation rows and one new test; nothing a user runs changes.
Removes nothing: rows are only added.
Tests
test_top_level_commands/test_sub_commands: every user-facing command is named in the skill.test_the_walk_finds_known_nested_commands,test_the_walk_leaves_internal_commands_out,test_the_matcher: the walk and the matcher cannot pass vacuously (aKIROCREW_DEBUG=1prefix is accepted;kasis not satisfied bykas-bundle).Proof: PROVEN test/test_kirocrew_commands_skill_coverage.py::TestEveryUserFacingCommandIsNamed::test_top_level_commands, test/test_kirocrew_commands_skill_coverage.py::TestEveryUserFacingCommandIsNamed::test_sub_commands (head 54e6da4)
Manual verification
Ran the new test against the skill as it was on main: it lists exactly the 17 commands above.
Related Issues
Closes #29816
Checklist